Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

[Kevin Wolf <kwolf@redhat.com>]

Am 28.11.2018 um 17:29 hat Paul Durrant geschrieben:
> > -----Original Message-----
> > From: Stefano Stabellini [mailto:sstabellini@kernel.org]
> > Sent: 28 November 2018 16:28
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: 'Kevin Wolf' <kwolf@redhat.com>; qemu-block@nongnu.org; qemu-
> > devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano Stabellini
> > <sstabellini@kernel.org>; Eduardo Habkost <ehabkost@redhat.com>; Michael
> > S. Tsirkin <mst@redhat.com>; Marcel Apfelbaum
> > <marcel.apfelbaum@gmail.com>; Anthony Perard <anthony.perard@citrix.com>;
> > Paolo Bonzini <pbonzini@redhat.com>; Richard Henderson <rth@twiddle.net>
> > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and
> > 'XenDevice' object hierarchy
> > 
> > On Wed, 28 Nov 2018, Paul Durrant wrote:
> > > > -----Original Message-----
> > > > From: Kevin Wolf [mailto:kwolf@redhat.com]
> > > > Sent: 28 November 2018 16:19
> > > > To: Paul Durrant <Paul.Durrant@citrix.com>
> > > > Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; xen-
> > > > devel@lists.xenproject.org; Stefano Stabellini
> > <sstabellini@kernel.org>;
> > > > Eduardo Habkost <ehabkost@redhat.com>; Michael S. Tsirkin
> > > > <mst@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>;
> > Anthony
> > > > Perard <anthony.perard@citrix.com>; Paolo Bonzini
> > <pbonzini@redhat.com>;
> > > > Richard Henderson <rth@twiddle.net>
> > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus'
> > and
> > > > 'XenDevice' object hierarchy
> > > >
> > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben:
> > > > > This patch adds the basic boilerplate for a 'XenBus' object that
> > will
> > > > act
> > > > > as a parent to 'XenDevice' PV backends.
> > > > > A new 'XenBridge' object is also added to connect XenBus to the
> > system
> > > > bus.
> > > > >
> > > > > The XenBus object is instantiated by a new xen_bus_init() function
> > > > called
> > > > > from the same sites as the legacy xen_be_init() function.
> > > > >
> > > > > Subsequent patches will flesh-out the functionality of these
> > objects.
> > > > >
> > > > > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > > >
> > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> > > > > new file mode 100644
> > > > > index 0000000000..dede2d914a
> > > > > --- /dev/null
> > > > > +++ b/hw/xen/xen-bus.c
> > > > > @@ -0,0 +1,125 @@
> > > > > +/*
> > > > > + * Copyright (c) Citrix Systems Inc.
> > > > > + * All rights reserved.
> > > > > + */
> > > >
> > > > This doesn't look very compatible with the GPL. In fact it might even
> > > > make it illegal for the QEMU project to distribute this code. :-)
> > > >
> > > > Other files you add throughout the series seem to have the same
> > problem.
> > > >
> > >
> > > I was working on the assumption that a lack of explicit license meant
> > that the overall project license as described in item 2 in LICENSE. Did I
> > misinterpret that text?
> > 
> > It's "All rights reserved." the problem
> 
> Oh, I see. I'm happy to remove that.

That would be better at least. I'm not sure about files that have a
copyright header, but no license statement. Do such files exist yet in
the source tree? To be on the safe side, I'd just stick with the
established practice, which is having a license header in every file.

By the way, in a later patch you remove the existing license header,
which is different from the default license (because parts of the source
file are GPL 2 only). If you can't prove that all such parts (and parts
derived from them) have been removed, this is also a problem.

Kevin