From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: mst@redhat.com, ppandit@redhat.com, liq3ea@163.com,
liq3ea@gmail.com, pbonzini@redhat.com,
Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets
Date: Thu, 29 Nov 2018 11:12:26 +0800 [thread overview]
Message-ID: <20181129031230.31082-1-jasowang@redhat.com> (raw)
Hi:
This series tries to fix a possible OOB during queueing packets
through qemu_net_queue_append_iov(). This could happen when it tries
to queue a packet whose size is larger than INT_MAX which may lead
integer overflow. We've fixed similar issue in the past during
qemu_net_queue_deliver_iov() by ignoring large packets there. Let's
just move the check earlier to qemu_sendv_packet_async() and reduce
the limitation to NET_BUFSIZE. A simple qtest were also added this.
Please review.
Thanks
Jason Wang (4):
net: drop too large packet early
virtio-net-test: remove unused macro
virtio-net-test: accept variable length argument in pci_test_start()
virtio-net-test: add large tx buffer test
net/net.c | 13 +++++----
tests/virtio-net-test.c | 64 ++++++++++++++++++++++++++++++++++++-----
2 files changed, 64 insertions(+), 13 deletions(-)
--
2.17.1
next reply other threads:[~2018-11-29 3:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 3:12 Jason Wang [this message]
2018-11-29 3:12 ` [Qemu-devel] [PATCH for 3.1 1/4] net: drop too large packet early Jason Wang
2018-11-29 3:43 ` Li Qiang
2018-11-29 3:12 ` [Qemu-devel] [PATCH for 3.1 2/4] virtio-net-test: remove unused macro Jason Wang
2018-11-29 6:17 ` Thomas Huth
2018-11-29 3:12 ` [Qemu-devel] [PATCH for 3.1 3/4] virtio-net-test: accept variable length argument in pci_test_start() Jason Wang
2018-11-29 6:16 ` Thomas Huth
2018-11-30 15:02 ` Eric Blake
2018-12-03 10:08 ` Jason Wang
2018-11-29 3:12 ` [Qemu-devel] [PATCH for 3.1 4/4] virtio-net-test: add large tx buffer test Jason Wang
2018-11-29 6:21 ` Thomas Huth
2018-11-29 12:15 ` Jason Wang
2018-11-30 3:48 ` [Qemu-devel] [PATCH for 3.1 0/4] Fix possible OOB during queuing packets no-reply
2018-11-30 3:49 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129031230.31082-1-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).