From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSICQ-0002Bi-DA for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:01:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSICK-0002oe-I9 for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:01:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56854) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gSICK-0002o6-Ap for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:01:24 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ACC4A89ADD for ; Thu, 29 Nov 2018 09:01:23 +0000 (UTC) From: Paolo Bonzini Date: Thu, 29 Nov 2018 10:01:17 +0100 Message-Id: <20181129090120.28828-2-pbonzini@redhat.com> In-Reply-To: <20181129090120.28828-1-pbonzini@redhat.com> References: <20181129090120.28828-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-4.0 1/4] checkpatch: fix premature exit when no input or --mailback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org In some cases, checkpatch's process subroutine is exiting the whole process. This is wrong, just return from the subroutine instead. Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index eccd656c41..d58fcb1efd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2869,19 +2869,19 @@ sub process { # If we have no input at all, then there is nothing to report on # so just keep quiet. if ($#rawlines =3D=3D -1) { - exit(0); + return 1; } =20 # In mailback mode only produce a report in the negative, for # things that appear to be patches. if ($mailback && ($clean =3D=3D 1 || !$is_patch)) { - exit(0); + return 1; } =20 # This is not a patch, and we are are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { - exit(0); + return 1; } =20 if (!$is_patch) { --=20 2.19.1