From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSIFn-000670-48 for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:05:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSIFj-00056i-4j for qemu-devel@nongnu.org; Thu, 29 Nov 2018 04:04:59 -0500 Date: Thu, 29 Nov 2018 10:04:38 +0100 From: Kevin Wolf Message-ID: <20181129090438.GB4797@linux.fritz.box> References: <20181121151211.15997-1-paul.durrant@citrix.com> <20181121151211.15997-3-paul.durrant@citrix.com> <20181128161917.GE4222@dhcp-200-186.str.redhat.com> <48596f1fe100419c8b28ed54bda0117b@AMSPEX02CL03.citrite.net> <65af28818a724749839dcb6576e0413d@AMSPEX02CL03.citrite.net> <20181128163900.GG4222@dhcp-200-186.str.redhat.com> <5327ba765089439caf8119de49c3a399@AMSPEX02CL03.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: 'Stefano Stabellini' , "'qemu-block@nongnu.org'" , "'qemu-devel@nongnu.org'" , "'xen-devel@lists.xenproject.org'" , 'Eduardo Habkost' , "'Michael S. Tsirkin'" , 'Marcel Apfelbaum' , Anthony Perard , 'Paolo Bonzini' , 'Richard Henderson' Am 28.11.2018 um 17:46 hat Paul Durrant geschrieben: > > -----Original Message----- > > From: Paul Durrant > > Sent: 28 November 2018 16:46 > > To: 'Kevin Wolf' > > Cc: 'Stefano Stabellini' ; qemu-block@nongnu.org; > > qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Eduardo Habkost > > ; Michael S. Tsirkin ; Marcel > > Apfelbaum ; Anthony Perard > > ; Paolo Bonzini ; Richard > > Henderson > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > 'XenDevice' object hierarchy > > > > > -----Original Message----- > > > From: Kevin Wolf [mailto:kwolf@redhat.com] > > > Sent: 28 November 2018 16:39 > > > To: Paul Durrant > > > Cc: 'Stefano Stabellini' ; qemu- > > block@nongnu.org; > > > qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Eduardo Habkost > > > ; Michael S. Tsirkin ; Marcel > > > Apfelbaum ; Anthony Perard > > > ; Paolo Bonzini ; > > Richard > > > Henderson > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and > > > 'XenDevice' object hierarchy > > > > > > Am 28.11.2018 um 17:29 hat Paul Durrant geschrieben: > > > > > -----Original Message----- > > > > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > > > > Sent: 28 November 2018 16:28 > > > > > To: Paul Durrant > > > > > Cc: 'Kevin Wolf' ; qemu-block@nongnu.org; qemu- > > > > > devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano Stabellini > > > > > ; Eduardo Habkost ; > > > Michael > > > > > S. Tsirkin ; Marcel Apfelbaum > > > > > ; Anthony Perard > > > ; > > > > > Paolo Bonzini ; Richard Henderson > > > > > > > > Subject: RE: [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' > > > and > > > > > 'XenDevice' object hierarchy > > > > > > > > > > On Wed, 28 Nov 2018, Paul Durrant wrote: > > > > > > > -----Original Message----- > > > > > > > From: Kevin Wolf [mailto:kwolf@redhat.com] > > > > > > > Sent: 28 November 2018 16:19 > > > > > > > To: Paul Durrant > > > > > > > Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; xen- > > > > > > > devel@lists.xenproject.org; Stefano Stabellini > > > > > ; > > > > > > > Eduardo Habkost ; Michael S. Tsirkin > > > > > > > ; Marcel Apfelbaum ; > > > > > Anthony > > > > > > > Perard ; Paolo Bonzini > > > > > ; > > > > > > > Richard Henderson > > > > > > > Subject: Re: [Qemu-block] [PATCH 02/18] xen: introduce new > > > 'XenBus' > > > > > and > > > > > > > 'XenDevice' object hierarchy > > > > > > > > > > > > > > Am 21.11.2018 um 16:11 hat Paul Durrant geschrieben: > > > > > > > > This patch adds the basic boilerplate for a 'XenBus' object > > that > > > > > will > > > > > > > act > > > > > > > > as a parent to 'XenDevice' PV backends. > > > > > > > > A new 'XenBridge' object is also added to connect XenBus to > > the > > > > > system > > > > > > > bus. > > > > > > > > > > > > > > > > The XenBus object is instantiated by a new xen_bus_init() > > > function > > > > > > > called > > > > > > > > from the same sites as the legacy xen_be_init() function. > > > > > > > > > > > > > > > > Subsequent patches will flesh-out the functionality of these > > > > > objects. > > > > > > > > > > > > > > > > Signed-off-by: Paul Durrant > > > > > > > > > > > > > > > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c > > > > > > > > new file mode 100644 > > > > > > > > index 0000000000..dede2d914a > > > > > > > > --- /dev/null > > > > > > > > +++ b/hw/xen/xen-bus.c > > > > > > > > @@ -0,0 +1,125 @@ > > > > > > > > +/* > > > > > > > > + * Copyright (c) Citrix Systems Inc. > > > > > > > > + * All rights reserved. > > > > > > > > + */ > > > > > > > > > > > > > > This doesn't look very compatible with the GPL. In fact it might > > > even > > > > > > > make it illegal for the QEMU project to distribute this code. :- > > ) > > > > > > > > > > > > > > Other files you add throughout the series seem to have the same > > > > > problem. > > > > > > > > > > > > > > > > > > > I was working on the assumption that a lack of explicit license > > > meant > > > > > that the overall project license as described in item 2 in LICENSE. > > > Did I > > > > > misinterpret that text? > > > > > > > > > > It's "All rights reserved." the problem > > > > > > > > Oh, I see. I'm happy to remove that. > > > > > > That would be better at least. I'm not sure about files that have a > > > copyright header, but no license statement. Do such files exist yet in > > > the source tree? > > > > Yes, there's quite a few... e.g. (first ones I tripped over) > > hw/rdma/rdma_backend.c, hw/virtio/vhost-backend.c, ... > > Oh... I see they have a license statement but no boilerplate... is > that statement enough? Yes, this is good enough. > > > To be on the safe side, I'd just stick with the > > > established practice, which is having a license header in every file. > > > > Ok... if that is established practice. It really wasn't clear. > > > > > > > > By the way, in a later patch you remove the existing license header, > > > which is different from the default license (because parts of the source > > > file are GPL 2 only). If you can't prove that all such parts (and parts > > > derived from them) have been removed, this is also a problem. > > > > > > > What should I do? I am duplicating xen_disk, and then heavily modifying > > it. Should I just leave the old boilerplate in place? Yes. Feel free to add your own copyright line right below Gerd's, but leave the old stuff intact. Kevin