qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [qemu-web PATCH v2] Document how to test the site with jekyll locally
Date: Thu, 29 Nov 2018 13:38:11 +0000	[thread overview]
Message-ID: <20181129133811.GD25007@redhat.com> (raw)
In-Reply-To: <14b6a1da-dc71-adbc-1911-a6e281229c43@redhat.com>

On Thu, Nov 29, 2018 at 07:34:56AM -0600, Eric Blake wrote:
> On 11/29/18 4:46 AM, Daniel P. Berrangé wrote:
> > Add a README file that tells people this is a jekyll based static
> > website, and shows people how to run jekyll for testing purposes.
> > 
> > Tested-by: Eric Blake <eblake@redhat.com>
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   .gitignore  |  2 ++
> >   README      | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >   _config.yml |  2 ++
> >   3 files changed, 59 insertions(+)
> >   create mode 100644 README
> 
> > +Testing locally with Jekyll
> > +---------------------------
> > +
> > +When adding/changing content on this site, it is possible to run a
> > +local Jekyll service to test the result.
> > +
> > +QEMU requires a specific version of Jekyll (listedin Gemfile) which may
> 
> s/listedin/listed in/
> 
> > +++ b/_config.yml
> > @@ -37,3 +37,5 @@ gems:
> >   exclude:
> >     - Gemfile
> >     - Gemfile.lock
> > +  - vendor/
> > +  - README
> 
> Should .gitignore be in this list?  But that's pre-existing.

AFAICT, it excludes all dotfiles by default

> 
> With the typo fix,
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

  reply	other threads:[~2018-11-29 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 10:46 [Qemu-devel] [qemu-web PATCH v2] Document how to test the site with jekyll locally Daniel P. Berrangé
2018-11-29 13:34 ` Eric Blake
2018-11-29 13:38   ` Daniel P. Berrangé [this message]
2018-11-29 13:47 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129133811.GD25007@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).