From: Greg Kurz <groug@kaod.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: qemu-devel@nongnu.org, Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Qemu-devel] [PATCH for 4.0 1/2] 9p: use g_new(T, n) instead of g_malloc(sizeof(T) * n)
Date: Thu, 29 Nov 2018 17:38:48 +0100 [thread overview]
Message-ID: <20181129173848.6b561d27@bahia.lan> (raw)
In-Reply-To: <20181129162648.GI14786@perard.uk.xensource.com>
On Thu, 29 Nov 2018 16:26:48 +0000
Anthony PERARD <anthony.perard@citrix.com> wrote:
> On Thu, Nov 29, 2018 at 04:47:12PM +0100, Greg Kurz wrote:
> > Because it is a recommended coding practice (see HACKING).
> >
> > Signed-off-by: Greg Kurz <groug@kaod.org>
>
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
>
> It would have been nice if there were a cover letter for these two
> patches, as we would had automatic build test and coding style test ;-).
>
Yeah... I had it ready and I simply forgot to pass it to stg mail :-\
I've pushed them to my 9p-next branch, which automatically triggers travis,
so I'll have the build test covered at least :)
Thanks for the review !
Cheers,
--
Greg
prev parent reply other threads:[~2018-11-29 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:47 [Qemu-devel] [PATCH for 4.0 1/2] 9p: use g_new(T, n) instead of g_malloc(sizeof(T) * n) Greg Kurz
2018-11-29 15:47 ` [Qemu-devel] [PATCH for 4.0 2/2] xen/9pfs: " Greg Kurz
2018-11-29 16:16 ` Anthony PERARD
2018-11-29 16:26 ` [Qemu-devel] [PATCH for 4.0 1/2] 9p: " Anthony PERARD
2018-11-29 16:38 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129173848.6b561d27@bahia.lan \
--to=groug@kaod.org \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).