qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia@oracle.com>
To: yuval.shaia@oracle.com, marcel.apfelbaum@gmail.com,
	dmitry.fleytman@gmail.com, jasowang@redhat.com,
	eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
	qemu-devel@nongnu.org, shamir.rabinovitch@oracle.com,
	cohuck@redhat.com
Subject: [Qemu-devel] [PATCH v6 22/23] hw/rdma: Do not call rdma_backend_del_gid on an empty gid
Date: Thu, 29 Nov 2018 23:48:04 +0200	[thread overview]
Message-ID: <20181129214805.2749-23-yuval.shaia@oracle.com> (raw)
In-Reply-To: <20181129214805.2749-1-yuval.shaia@oracle.com>

When device goes down the function fini_ports loops over all entries in
gid table regardless of the fact whether entry is valid or not. In case
that entry is not valid we'd like to skip from any further processing in
backend device.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 hw/rdma/rdma_rm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
index ca127c8c26..f5b1295890 100644
--- a/hw/rdma/rdma_rm.c
+++ b/hw/rdma/rdma_rm.c
@@ -555,6 +555,10 @@ int rdma_rm_del_gid(RdmaDeviceResources *dev_res, RdmaBackendDev *backend_dev,
 {
     int rc;
 
+    if (!dev_res->port.gid_tbl[gid_idx].gid.global.interface_id) {
+        return 0;
+    }
+
     rc = rdma_backend_del_gid(backend_dev, ifname,
                               &dev_res->port.gid_tbl[gid_idx].gid);
     if (rc) {
-- 
2.17.2

  parent reply	other threads:[~2018-11-29 21:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 21:47 [Qemu-devel] [PATCH v6 00/23] Add support for RDMA MAD Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 01/23] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 02/23] hw/rdma: Add ability to force notification without re-arm Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 03/23] hw/rdma: Return qpn 1 if ibqp is NULL Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 04/23] hw/rdma: Abort send-op if fail to create addr handler Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 05/23] hw/rdma: Add support for MAD packets Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 06/23] hw/pvrdma: Make function reset_device return void Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 07/23] hw/pvrdma: Make default pkey 0xFFFF Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 08/23] hw/pvrdma: Set the correct opcode for recv completion Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 09/23] hw/pvrdma: Set the correct opcode for send completion Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 10/23] qapi: Define new QMP message for pvrdma Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 11/23] hw/pvrdma: Add support to allow guest to configure GID table Yuval Shaia
2018-12-05  6:10   ` Marcel Apfelbaum
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 12/23] vmxnet3: Move some definitions to header file Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 13/23] hw/pvrdma: Make sure PCI function 0 is vmxnet3 Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 14/23] hw/rdma: Initialize node_guid from vmxnet3 mac address Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 15/23] hw/pvrdma: Make device state depend on Ethernet function state Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 16/23] hw/pvrdma: Fill all CQE fields Yuval Shaia
2018-11-29 21:47 ` [Qemu-devel] [PATCH v6 17/23] hw/pvrdma: Fill error code in command's response Yuval Shaia
2018-11-29 21:48 ` [Qemu-devel] [PATCH v6 18/23] hw/rdma: Remove unneeded code that handles more that one port Yuval Shaia
2018-11-29 21:48 ` [Qemu-devel] [PATCH v6 19/23] vl: Introduce shutdown_notifiers Yuval Shaia
2018-11-29 21:48 ` [Qemu-devel] [PATCH v6 20/23] hw/pvrdma: Clean device's resource when system is shutdown Yuval Shaia
2018-11-29 21:48 ` [Qemu-devel] [PATCH v6 21/23] hw/rdma: Do not use bitmap_zero_extend to free bitmap Yuval Shaia
2018-11-29 21:48 ` Yuval Shaia [this message]
2018-11-29 21:48 ` [Qemu-devel] [PATCH v6 23/23] docs: Update pvrdma device documentation Yuval Shaia
2018-12-05  6:12   ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129214805.2749-23-yuval.shaia@oracle.com \
    --to=yuval.shaia@oracle.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shamir.rabinovitch@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).