qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com, jsnow@redhat.com,
	qemu-stable@nongnu.org,
	"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH 1/3] nbd/server: Advertise all contexts in response to bare LIST
Date: Thu, 29 Nov 2018 20:32:30 -0600	[thread overview]
Message-ID: <20181130023232.3079982-2-eblake@redhat.com> (raw)
In-Reply-To: <20181130023232.3079982-1-eblake@redhat.com>

The NBD spec, and even our code comment, says that if the client
asks for NBD_OPT_LIST_META_CONTEXT with 0 queries, then we should
reply with (a possibly-compressed representation of) ALL contexts
that we are willing to let them try.  But commit 3d068aff forgot
to advertise qemu:dirty-bitmap:FOO.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 nbd/server.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nbd/server.c b/nbd/server.c
index dc04513de70..7af0ddffb20 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -978,6 +978,7 @@ static int nbd_negotiate_meta_queries(NBDClient *client,
     if (client->opt == NBD_OPT_LIST_META_CONTEXT && !nb_queries) {
         /* enable all known contexts */
         meta->base_allocation = true;
+        meta->bitmap = !!meta->exp->export_bitmap;
     } else {
         for (i = 0; i < nb_queries; ++i) {
             ret = nbd_negotiate_meta_query(client, meta, errp);
-- 
2.17.2

  reply	other threads:[~2018-11-30  2:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  2:32 [Qemu-devel] [PATCH for-3.1? 0/3] NBD dirty bitmap cleanups Eric Blake
2018-11-30  2:32 ` Eric Blake [this message]
2018-11-30  8:02   ` [Qemu-devel] [PATCH 1/3] nbd/server: Advertise all contexts in response to bare LIST Vladimir Sementsov-Ogievskiy
2018-11-30  2:32 ` [Qemu-devel] [PATCH 2/3] nbd/client: Make x-dirty-bitmap more reliable Eric Blake
2018-11-30  8:21   ` Vladimir Sementsov-Ogievskiy
2018-11-30  2:32 ` [Qemu-devel] [PATCH 3/3] nbd/client: Send NBD_CMD_DISC if open fails after connect Eric Blake
2018-11-30  8:29   ` Vladimir Sementsov-Ogievskiy
2018-11-30 15:25 ` [Qemu-devel] [PATCH for-3.1? 0/3] NBD dirty bitmap cleanups Eric Blake
2018-12-03 15:03   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181130023232.3079982-2-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).