From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [Qemu-devel] [PATCH v7 03/11] hw/usb: don't set IN_ISDIR for inotify watch in MTP driver
Date: Fri, 30 Nov 2018 14:06:07 +0000 [thread overview]
Message-ID: <20181130140615.19937-4-berrange@redhat.com> (raw)
In-Reply-To: <20181130140615.19937-1-berrange@redhat.com>
IN_ISDIR is not a bit that one can request when registering a
watch with inotify_add_watch. Rather it is a bit that is set
automatically when reading events from the kernel.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 00a3691bae..f026419e47 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -642,8 +642,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s)
static int usb_mtp_add_watch(int inotifyfd, char *path)
{
- uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY |
- IN_ISDIR;
+ uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY;
return inotify_add_watch(inotifyfd, path, mask);
}
--
2.19.2
next prev parent reply other threads:[~2018-11-30 14:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 14:06 [Qemu-devel] [PATCH v7 00/11] Add a standard authorization framework Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 01/11] util: add helper APIs for dealing with inotify in portable manner Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 02/11] qom: don't require user creatable objects to be registered Daniel P. Berrangé
2018-11-30 14:06 ` Daniel P. Berrangé [this message]
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 04/11] hw/usb: fix const-ness for string params in MTP driver Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 05/11] hw/usb: switch MTP to use new inotify APIs Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 06/11] authz: add QAuthZ object as an authorization base class Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 07/11] authz: add QAuthZSimple object type for easy whitelist auth checks Daniel P. Berrangé
2018-12-05 17:13 ` Philippe Mathieu-Daudé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 08/11] authz: add QAuthZList object type for an access control list Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 09/11] authz: add QAuthZListFile object type for a file " Daniel P. Berrangé
2018-12-05 17:23 ` Philippe Mathieu-Daudé
2018-12-05 21:55 ` Eric Blake
2018-12-06 15:58 ` Philippe Mathieu-Daudé
2018-12-06 17:07 ` Eric Blake
2018-12-06 17:48 ` Philippe Mathieu-Daudé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 10/11] authz: add QAuthZPAM object type for authorizing using PAM Daniel P. Berrangé
2018-11-30 14:06 ` [Qemu-devel] [PATCH v7 11/11] authz: delete existing ACL implementation Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130140615.19937-4-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).