From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSmON-0004yv-4Q for qemu-devel@nongnu.org; Fri, 30 Nov 2018 12:15:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSmJ9-00058g-Mu for qemu-devel@nongnu.org; Fri, 30 Nov 2018 12:10:30 -0500 Received: from 1.mo177.mail-out.ovh.net ([178.33.107.143]:51225) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gSmJ9-00058H-FL for qemu-devel@nongnu.org; Fri, 30 Nov 2018 12:10:27 -0500 Received: from player792.ha.ovh.net (unknown [10.109.143.216]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id F24B0D5EF9 for ; Fri, 30 Nov 2018 18:10:24 +0100 (CET) Date: Fri, 30 Nov 2018 18:10:20 +0100 From: Greg Kurz Message-ID: <20181130181020.11a4bcec@bahia.lan> In-Reply-To: References: <154356772378.66975.13711686652368325931.stgit@bahia.lan> <20181130174548.247d293c@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-3.1?] 9p: remove support for the "handle" backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Eric Blake , QEMU Developers , Thomas Huth On Fri, 30 Nov 2018 17:00:29 +0000 Peter Maydell wrote: > On Fri, 30 Nov 2018 at 16:45, Greg Kurz wrote: > > > > On Fri, 30 Nov 2018 09:52:18 -0600 > > Eric Blake wrote: > > > > > On 11/30/18 2:49 AM, Greg Kurz wrote: > > > > The "handle" fsdev backend was deprecated in QEMU 2.12.0 with: > > > > > > > > commit db3b3c7281ca82e2647e072a1f97db111313dd73 > > > > Author: Greg Kurz > > > > Date: Mon Jan 8 11:18:23 2018 +0100 > > > > > > > > 9pfs: deprecate handle backend > > > > > > > It has passed the two release cooling period without any complaint. > > > > > > > > Remove it now. > > > > > > > > Signed-off-by: Greg Kurz > > > > --- > > > > > > > > It could have been removed for 3.1.0, but I woke up too late, so moving > > > > this to 4.0. > > > > > > > > --- > > > > fsdev/qemu-fsdev.c | 3 > > > > hw/9pfs/9p-handle.c | 710 ------------------------------------------------- > > > > hw/9pfs/Makefile.objs | 1 > > > > qemu-deprecated.texi | 8 - > > > > qemu-options.hx | 8 - > > > > 5 files changed, 4 insertions(+), 726 deletions(-) > > > > delete mode 100644 hw/9pfs/9p-handle.c > > > > > > Well, it certainly doesn't drive -rc4 on its own, but as we may have an > > > -rc4 for other reasons, maybe it could still be argued that this is 3.1 > > > material on the grounds of removing questionable code for less attack > > > exposure? > > > > > > > Makes sense, as this is precisely the reason that led me to > > deprecate this in the first place. > > I would prefer not to have a 700-line patch in rc4, even > a negative-diffstat one. If it's not a definite problem > then we shouldn't put the change in at this stage in the > release process. > I understand, and it's ok for me if this gets merged in 4.0. Cheers, -- Greg > thanks > -- PMM