From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: [Qemu-devel] [PATCH v3 01/16] tcg/i386: Always use %ebp for TCG_AREG0
Date: Fri, 30 Nov 2018 13:52:06 -0800 [thread overview]
Message-ID: <20181130215221.20554-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20181130215221.20554-1-richard.henderson@linaro.org>
For x86_64, this can remove a REX prefix resulting in smaller code
when manipulating globals of type i32, as we move them between backing
store via cpu_env, aka TCG_AREG0.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/i386/tcg-target.h | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h
index 9fdf37f23c..7488c3d869 100644
--- a/tcg/i386/tcg-target.h
+++ b/tcg/i386/tcg-target.h
@@ -84,6 +84,8 @@ typedef enum {
TCG_REG_RBP = TCG_REG_EBP,
TCG_REG_RSI = TCG_REG_ESI,
TCG_REG_RDI = TCG_REG_EDI,
+
+ TCG_AREG0 = TCG_REG_EBP,
} TCGReg;
/* used for function call generation */
@@ -194,12 +196,6 @@ extern bool have_avx2;
#define TCG_TARGET_extract_i64_valid(ofs, len) \
(((ofs) == 8 && (len) == 8) || ((ofs) + (len)) == 32)
-#if TCG_TARGET_REG_BITS == 64
-# define TCG_AREG0 TCG_REG_R14
-#else
-# define TCG_AREG0 TCG_REG_EBP
-#endif
-
static inline void flush_icache_range(uintptr_t start, uintptr_t stop)
{
}
--
2.17.2
next prev parent reply other threads:[~2018-11-30 21:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 21:52 [Qemu-devel] [PATCH v3 00/16] tcg: Assorted cleanups Richard Henderson
2018-11-30 21:52 ` Richard Henderson [this message]
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 02/16] tcg/i386: Move TCG_REG_CALL_STACK from define to enum Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 03/16] tcg/aarch64: Remove reloc_pc26_atomic Richard Henderson
2018-12-03 8:44 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 04/16] tcg/aarch64: Fold away "noaddr" branch routines Richard Henderson
2018-12-03 15:49 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 05/16] tcg/arm: Remove reloc_pc24_atomic Richard Henderson
2018-12-03 15:49 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 06/16] tcg/arm: Fold away "noaddr" branch routines Richard Henderson
2018-12-03 10:33 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 07/16] tcg/ppc: " Richard Henderson
2018-12-03 10:35 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 08/16] tcg/s390: Remove retranslation code Richard Henderson
2018-12-03 10:37 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 09/16] tcg/sparc: " Richard Henderson
2018-12-03 10:39 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 10/16] tcg/mips: " Richard Henderson
2018-12-03 10:39 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 11/16] tcg: Return success from patch_reloc Richard Henderson
2018-12-03 10:40 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 12/16] tcg/i386: Return false on failure " Richard Henderson
2018-12-03 10:40 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 13/16] tcg/aarch64: " Richard Henderson
2018-12-03 10:43 ` Alex Bennée
2018-12-03 13:23 ` Richard Henderson
2018-12-03 14:15 ` Alex Bennée
2018-12-03 14:31 ` Richard Henderson
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 14/16] tcg/arm: " Richard Henderson
2018-12-03 10:43 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 15/16] tcg/ppc: " Richard Henderson
2018-12-03 10:44 ` Alex Bennée
2018-11-30 21:52 ` [Qemu-devel] [PATCH v3 16/16] tcg/s390x: " Richard Henderson
2018-12-03 10:46 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130215221.20554-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).