Re: [Qemu-devel] [PATCH V10 7/9] hw/misc/pvpanic: preparing for adding configure interface

[<peng.hao2@zte.com.cn>]

>On Wed, 28 Nov 2018 at 03:50, Peng Hao <peng.hao2@zte.com.cn> wrote:
>>
>> Prepare for pvpanic-mmio configure interface.
>>
>> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
>> ---
>>  hw/arm/sysbus-fdt.c |  2 ++
>>  hw/arm/virt.c       |  2 ++
>>  hw/misc/pvpanic.c   | 11 +++++++++--
>>  3 files changed, 13 insertions(+), 2 deletions(-)
>
>This looks rather odd. The sysbus-fdt.c code is for
>handling devices that we must pass through from the
>host system (including pulling in device tree fragments
>from the host). The pvpanic device isn't a host pass
>through device so I don't think it should be touching
>that code at all. It's just a simple MMIO device.
>
>I suspect the reason you've done this is that you're
>trying to get "-device pvpanic" to work on the command
>line. I recommend not trying to get that to work.
>MMIO devices are not pluggable devices, and -device
>is not expected to work with them.
>
yes, I use -device pvpanic-mmio. Thank you for pointing this out.
 I also felt a little odd when I realized it. But I didn't think about the reason.
I think I can use a way like iommu, and I've thought about it in doing my 
current way.
thanks.
>thanks
>-- PMM