qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
	mst@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
	pbonzini@redhat.com, liliang.opensource@gmail.com,
	nilal@redhat.com, riel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v10 3/7] migration: use bitmap_mutex in migration_bitmap_clear_dirty
Date: Mon, 3 Dec 2018 13:08:23 +0800	[thread overview]
Message-ID: <20181203050823.GA27620@xz-x1> (raw)
In-Reply-To: <1543803511-34793-4-git-send-email-wei.w.wang@intel.com>

On Mon, Dec 03, 2018 at 10:18:27AM +0800, Wei Wang wrote:
> The bitmap mutex is used to synchronize threads to update the dirty
> bitmap and the migration_dirty_pages counter. For example, the free
> page optimization clears bits of free pages from the bitmap in an
> iothread context. This patch makes migration_bitmap_clear_dirty update
> the bitmap and counter under the mutex.
> 
> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
> CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
> CC: Juan Quintela <quintela@redhat.com>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Peter Xu <peterx@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

  reply	other threads:[~2018-12-03  5:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  2:18 [Qemu-devel] [PATCH v10 0/7] virtio-balloon: free page hint support Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 1/7] bitmap: fix bitmap_count_one Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 2/7] bitmap: bitmap_count_one_with_offset Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 3/7] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang
2018-12-03  5:08   ` Peter Xu [this message]
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 4/7] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang
2018-12-03  5:10   ` Peter Xu
2018-12-03  8:07     ` Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 5/7] migration/ram.c: add a notifier chain for precopy Wei Wang
2018-12-03  5:20   ` Peter Xu
2018-12-03  8:10     ` Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 6/7] migration/ram.c: add a function to disable the bulk stage Wei Wang
2018-12-03  5:31   ` Peter Xu
2018-12-03  8:20     ` Wei Wang
2018-12-03  8:24       ` [Qemu-devel] [virtio-dev] " Wei Wang
2018-12-03  2:18 ` [Qemu-devel] [PATCH v10 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181203050823.GA27620@xz-x1 \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=liliang.opensource@gmail.com \
    --cc=mst@redhat.com \
    --cc=nilal@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=riel@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).