From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gU1mu-0006k4-Hh for qemu-devel@nongnu.org; Mon, 03 Dec 2018 22:54:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gU1mj-0005SI-Cu for qemu-devel@nongnu.org; Mon, 03 Dec 2018 22:54:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59266) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gU1mi-0005Ps-4z for qemu-devel@nongnu.org; Mon, 03 Dec 2018 22:54:08 -0500 From: Jason Wang Date: Tue, 4 Dec 2018 11:53:42 +0800 Message-Id: <20181204035347.6148-1-jasowang@redhat.com> Subject: [Qemu-devel] [PATCH V5 for 3.1 0/5] Fix possible OOB during queuing packets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: mst@redhat.com, ppandit@redhat.com, liq3ea@163.com, liq3ea@gmail.com, pbonzini@redhat.com, thuth@redhat.com, eblake@redhat.com, Jason Wang Hi: This series tries to fix a possible OOB during queueing packets through qemu_net_queue_append_iov(). This could happen when it tries to queue a packet whose size is larger than INT_MAX which may lead integer overflow. We've fixed similar issue in the past during qemu_net_queue_deliver_iov() by ignoring large packets there. Let's just move the check earlier to qemu_sendv_packet_async() and reduce the limitation to NET_BUFSIZE. A simple qtest were also added this. Please review. Thanks Changes from V1: - slient compiling warnings Changes from V2: - annotate pci_test_start() with GCC_FMT_ATTR() - drop intermediate cmd string variable Changes from V4: - silent hub warning if qtest is enabled - make qemu_deliver_packet_iov() static - add one more test for packet size slightly greater than NET_BUFSIZE - tweak the commit log and add more justification - typo/whitespace fixes and other minor code style tweaks Jason Wang (5): net: drop too large packet early net: hub: suppress warnings of no host network for qtest virtio-net-test: accept variable length argument in pci_test_start() virtio-net-test: remove unused macro virtio-net-test: add large tx buffer test include/net/net.h | 6 ---- net/hub.c | 3 +- net/net.c | 28 +++++++++++------- tests/virtio-net-test.c | 64 ++++++++++++++++++++++++++++++++++++----- 4 files changed, 76 insertions(+), 25 deletions(-) -- 2.17.1