From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: mst@redhat.com, ppandit@redhat.com, liq3ea@163.com,
liq3ea@gmail.com, pbonzini@redhat.com, thuth@redhat.com,
eblake@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH V5 for 3.1 2/5] net: hub: suppress warnings of no host network for qtest
Date: Tue, 4 Dec 2018 11:53:44 +0800 [thread overview]
Message-ID: <20181204035347.6148-3-jasowang@redhat.com> (raw)
In-Reply-To: <20181204035347.6148-1-jasowang@redhat.com>
If we want to qtest through hub, it would be much more simpler and
safer to configure the hub without host network. So silent this
warnings for qtest.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/hub.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/hub.c b/net/hub.c
index 78b671ed95..5795a678ed 100644
--- a/net/hub.c
+++ b/net/hub.c
@@ -20,6 +20,7 @@
#include "hub.h"
#include "qemu/iov.h"
#include "qemu/error-report.h"
+#include "sysemu/qtest.h"
/*
* A hub broadcasts incoming packets to all its ports except the source port.
@@ -346,7 +347,7 @@ void net_hub_check_clients(void)
if (has_host_dev && !has_nic) {
warn_report("hub %d with no nics", hub->id);
}
- if (has_nic && !has_host_dev) {
+ if (has_nic && !has_host_dev && !qtest_enabled()) {
warn_report("hub %d is not connected to host network", hub->id);
}
}
--
2.17.1
next prev parent reply other threads:[~2018-12-04 3:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 3:53 [Qemu-devel] [PATCH V5 for 3.1 0/5] Fix possible OOB during queuing packets Jason Wang
2018-12-04 3:53 ` [Qemu-devel] [PATCH V5 for 3.1 1/5] net: drop too large packet early Jason Wang
2018-12-04 5:53 ` Thomas Huth
2018-12-04 3:53 ` Jason Wang [this message]
2018-12-04 5:58 ` [Qemu-devel] [PATCH V5 for 3.1 2/5] net: hub: suppress warnings of no host network for qtest Thomas Huth
2018-12-04 3:53 ` [Qemu-devel] [PATCH V5 for 3.1 3/5] virtio-net-test: accept variable length argument in pci_test_start() Jason Wang
2018-12-04 3:53 ` [Qemu-devel] [PATCH V5 for 3.1 4/5] virtio-net-test: remove unused macro Jason Wang
2018-12-04 3:53 ` [Qemu-devel] [PATCH V5 for 3.1 5/5] virtio-net-test: add large tx buffer test Jason Wang
2018-12-04 6:07 ` Thomas Huth
2018-12-04 11:40 ` [Qemu-devel] [PATCH V5 for 3.1 0/5] Fix possible OOB during queuing packets Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204035347.6148-3-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=eblake@redhat.com \
--cc=liq3ea@163.com \
--cc=liq3ea@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).