From: Kevin Wolf <kwolf@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-block@nongnu.org, peter.maydell@linaro.org,
qemu-s390x <qemu-s390x@nongnu.org>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Max Reitz <mreitz@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [qemu-s390x] [PULL 2/2] iotests: simple mirror test with kvm on 1G image
Date: Wed, 5 Dec 2018 09:46:14 +0100 [thread overview]
Message-ID: <20181205084614.GA4018@dhcp-200-186.str.redhat.com> (raw)
In-Reply-To: <d0966d94-87d4-0f25-f2e0-846a1d338be7@de.ibm.com>
Am 05.12.2018 um 09:23 hat Christian Borntraeger geschrieben:
> >>> +# prepare source image
> >>> +qemu_img_create('-f', iotests.imgfmt, '-o', 'preallocation=metadata', disk,
> >>> + str(size))
> >>> +
> >>> +vm = QEMUMachine(iotests.qemu_prog)
> >>> +vm.add_args('-machine', 'pc,accel=kvm')
>
> This (pc) clearly does not work on other architectures.
> In addition to that, I also need to add -no-shutdown on s390 (see 068 for a similar case)
Leaving out pc definitely makes sense, and the bug still reproduces for
me without it.
I don't understand the -no-shutdown, though. Already for 068, neither
the code nor the commit message when it was added explain why this is
needed.
Can you turn this into a proper patch and add a comment why -no-shutdown
is needed?
Kevin
next prev parent reply other threads:[~2018-12-05 8:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 16:58 [Qemu-devel] [PULL 0/2] Block layer patches Kevin Wolf
2018-12-03 16:58 ` [Qemu-devel] [PULL 1/2] mirror: fix dead-lock Kevin Wolf
2018-12-03 16:58 ` [Qemu-devel] [PULL 2/2] iotests: simple mirror test with kvm on 1G image Kevin Wolf
[not found] ` <dc86835f-65d9-cada-dc9b-1f2c708521f9@de.ibm.com>
[not found] ` <75f7e3cc-bd46-c743-84ab-cd68bcb1dcfb@de.ibm.com>
2018-12-05 8:23 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-12-05 8:46 ` Kevin Wolf [this message]
2018-12-05 9:01 ` Christian Borntraeger
2018-12-05 12:00 ` Vladimir Sementsov-Ogievskiy
2018-12-05 12:35 ` Christian Borntraeger
2018-12-05 13:39 ` Vladimir Sementsov-Ogievskiy
2018-12-05 15:52 ` Christian Borntraeger
2018-12-05 16:09 ` Vladimir Sementsov-Ogievskiy
2018-12-05 16:23 ` Christian Borntraeger
2018-12-06 11:05 ` Christian Borntraeger
2018-12-07 12:14 ` Kevin Wolf
2018-12-03 17:43 ` [Qemu-devel] [PULL 0/2] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205084614.GA4018@dhcp-200-186.str.redhat.com \
--to=kwolf@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).