From: Stefan Hajnoczi <stefanha@gmail.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>
Cc: xiaoguangrong.eric@gmail.com, dan.j.williams@intel.com,
stefanha@redhat.com, pbonzini@redhat.com,
yu.c.zhang@linux.intel.com, imammedo@redhat.com,
qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto
Date: Wed, 5 Dec 2018 09:49:05 +0000 [thread overview]
Message-ID: <20181205094905.GD20933@stefanha-x1.localdomain> (raw)
In-Reply-To: <904316e1b1eb22d7a2d19fa00ffba17e65acda3b.1541425595.git.yi.z.zhang@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Mon, Nov 05, 2018 at 04:29:30PM +0800, Zhang Yi wrote:
> diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c
> index f411df7..fe9303f 100644
> --- a/util/mmap-alloc.c
> +++ b/util/mmap-alloc.c
> @@ -111,6 +111,10 @@ void *qemu_ram_mmap(int fd, size_t size, size_t align, uint32_t flags)
> assert(is_power_of_2(align));
> /* Always align to host page size */
> assert(align >= getpagesize());
> + if ((flags & RAM_SYNC_ON_OFF_AUTO_ON) &&
> + (!shared || !MAP_SYNC_FLAGS)) {
> + return MAP_FAILED;
> + }
Missing munmap(ptr, total)?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-12-05 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 8:07 [Qemu-devel] [PATCH v5 0/7] nvdimm: support MAP_SYNC for memory-backend-file Zhang Yi
2018-11-05 8:08 ` [Qemu-devel] [PATCH v5 1/7] numa: Fixed the memory leak of numa error message Zhang Yi
2018-11-05 8:08 ` [Qemu-devel] [PATCH v5 2/7] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter Zhang Yi
2018-12-05 9:20 ` Stefan Hajnoczi
2018-11-05 8:29 ` [Qemu-devel] [PATCH v5 3/7] exec: switch qemu_ram_alloc_from_{file, fd} to the " Zhang Yi
2018-11-05 8:29 ` [Qemu-devel] [PATCH v5 4/7] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Zhang Yi
2018-12-05 9:42 ` Stefan Hajnoczi
2018-11-05 8:29 ` [Qemu-devel] [PATCH v5 5/7] util/mmap-alloc: Switch the RAM_SYNC flags to OnOffAuto Zhang Yi
2018-12-05 9:49 ` Stefan Hajnoczi [this message]
2018-11-05 8:29 ` [Qemu-devel] [PATCH v5 6/7] hostmem: add more information in error messages Zhang Yi
2018-11-05 8:29 ` [Qemu-devel] [PATCH v5 7/7] hostmem-file: add 'sync' option Zhang Yi
2018-12-05 9:59 ` [Qemu-devel] [PATCH v5 0/7] nvdimm: support MAP_SYNC for memory-backend-file Stefan Hajnoczi
2018-12-12 6:27 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205094905.GD20933@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).