From: "Emilio G. Cota" <cota@braap.org>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Alex Benn?e <alex.bennee@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-ppc <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat
Date: Wed, 5 Dec 2018 11:08:52 -0500 [thread overview]
Message-ID: <20181205160852.GA8760@flamenco> (raw)
In-Reply-To: <BB2DCBB2-1B72-4986-BB21-3A685D68EF88@gmail.com>
On Wed, Dec 05, 2018 at 06:07:44 -0500, Programmingkid wrote:
>
> > On Dec 4, 2018, at 2:10 PM, qemu-devel-request@nongnu.org wrote:
> >
> > Emilio G. Cota <cota@braap.org> writes:
> >
> >> On Tue, Dec 04, 2018 at 13:52:16 +0000, Alex Benn?e wrote:
> >>>> We could always
> >>>>
> >>>> #ifdef __FAST_MATH__
> >>>> #error "Silliness like this will get you nowhere"
> >>>> #endif
> >>>
> >>> Emilio, are you happy to add that guard with a suitable pithy comment?
> >>
> >> Isn't it better to just disable hardfloat then?
> >>
> >> --- a/fpu/softfloat.c
> >> +++ b/fpu/softfloat.c
> >> @@ -220,7 +220,7 @@ GEN_INPUT_FLUSH3(float64_input_flush3, float64)
> >> * the use of hardfloat, since hardfloat relies on the inexact flag being
> >> * already set.
> >> */
> >> -#if defined(TARGET_PPC)
> >> +#if defined(TARGET_PPC) || defined(__FAST_MATH__)
> >> # define QEMU_NO_HARDFLOAT 1
> >> # define QEMU_SOFTFLOAT_ATTR QEMU_FLATTEN
> >> #else
>
> Why can't PowerPC also benefit from a hardfloat? It uses IEEE754 also.
Please see this message:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04974.html
Thanks,
E.
next prev parent reply other threads:[~2018-12-05 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.26358.1543950647.1282.qemu-devel@nongnu.org>
2018-12-05 11:07 ` [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat Programmingkid
2018-12-05 16:08 ` Emilio G. Cota [this message]
2018-11-24 23:55 [Qemu-devel] [PATCH v6 00/13] hardfloat Emilio G. Cota
2018-11-24 23:55 ` [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat Emilio G. Cota
2018-11-25 0:25 ` Aleksandar Markovic
2018-11-25 1:25 ` Emilio G. Cota
2018-12-04 12:28 ` Alex Bennée
2018-12-04 13:33 ` Richard Henderson
2018-12-04 13:52 ` Alex Bennée
2018-12-04 17:31 ` Emilio G. Cota
2018-12-04 19:08 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205160852.GA8760@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).