From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUZjP-0001qB-5P for qemu-devel@nongnu.org; Wed, 05 Dec 2018 11:09:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUZjL-0000f6-1P for qemu-devel@nongnu.org; Wed, 05 Dec 2018 11:08:58 -0500 Date: Wed, 5 Dec 2018 11:08:52 -0500 From: "Emilio G. Cota" Message-ID: <20181205160852.GA8760@flamenco> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v6 07/13] fpu: introduce hardfloat List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Programmingkid Cc: Alex Benn?e , Richard Henderson , QEMU Developers , qemu-ppc On Wed, Dec 05, 2018 at 06:07:44 -0500, Programmingkid wrote: > > > On Dec 4, 2018, at 2:10 PM, qemu-devel-request@nongnu.org wrote: > > > > Emilio G. Cota writes: > > > >> On Tue, Dec 04, 2018 at 13:52:16 +0000, Alex Benn?e wrote: > >>>> We could always > >>>> > >>>> #ifdef __FAST_MATH__ > >>>> #error "Silliness like this will get you nowhere" > >>>> #endif > >>> > >>> Emilio, are you happy to add that guard with a suitable pithy comment? > >> > >> Isn't it better to just disable hardfloat then? > >> > >> --- a/fpu/softfloat.c > >> +++ b/fpu/softfloat.c > >> @@ -220,7 +220,7 @@ GEN_INPUT_FLUSH3(float64_input_flush3, float64) > >> * the use of hardfloat, since hardfloat relies on the inexact flag being > >> * already set. > >> */ > >> -#if defined(TARGET_PPC) > >> +#if defined(TARGET_PPC) || defined(__FAST_MATH__) > >> # define QEMU_NO_HARDFLOAT 1 > >> # define QEMU_SOFTFLOAT_ATTR QEMU_FLATTEN > >> #else > > Why can't PowerPC also benefit from a hardfloat? It uses IEEE754 also. Please see this message: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04974.html Thanks, E.