qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Zhang Chen" <zhangckid@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	peterx@redhat.com, "Jason Wang" <jasowang@redhat.com>,
	"Li Zhijian" <lizhijian@cn.fujitsu.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context
Date: Thu,  6 Dec 2018 00:37:35 +0400	[thread overview]
Message-ID: <20181205203737.9011-6-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20181205203737.9011-1-marcandre.lureau@redhat.com>

COLO uses a worker context (iothread) to drive the chardev. All
backends are not able to switch the context, let's report an error in
this case.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 net/colo-compare.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/net/colo-compare.c b/net/colo-compare.c
index a39191d522..9156ab3349 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr,
         return 1;
     }
 
+    if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
+        error_setg(errp, "chardev \"%s\" cannot switch context",
+                   chr_name);
+        return 1;
+    }
+
     return 0;
 }
 
-- 
2.20.0.rc1

  parent reply	other threads:[~2018-12-05 20:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 20:37 [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 1/7] monitor: inline ambiguous helper functions Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 2/7] monitor: accept chardev input from iothread Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 3/7] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag Marc-André Lureau
2018-12-06  5:45   ` Markus Armbruster
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB Marc-André Lureau
2018-12-06  5:46   ` Markus Armbruster
2018-12-06  6:08   ` Markus Armbruster
2018-12-06  6:23     ` Marc-André Lureau
2018-12-06  9:13       ` Markus Armbruster
2018-12-06  9:24         ` Marc-André Lureau
2018-12-06  9:38           ` Markus Armbruster
2018-12-06  9:55             ` Marc-André Lureau
2018-12-06 12:58               ` Markus Armbruster
2018-12-05 20:37 ` Marc-André Lureau [this message]
2018-12-06  5:48   ` [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context Markus Armbruster
2018-12-06  5:56   ` Li Zhijian
2018-12-06  6:23   ` Zhang Chen
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 6/7] monitor: prevent inserting new monitors after cleanup Marc-André Lureau
2018-12-05 20:37 ` [Qemu-devel] [PATCH for-4.0 v4 7/7] monitor: avoid potential dead-lock when cleaning up Marc-André Lureau
2018-12-06 13:08 ` [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205203737.9011-6-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangckid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).