From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUdwD-0007eo-K8 for qemu-devel@nongnu.org; Wed, 05 Dec 2018 15:38:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUdwC-0002gO-VO for qemu-devel@nongnu.org; Wed, 05 Dec 2018 15:38:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33164) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gUdwC-0002g9-Q7 for qemu-devel@nongnu.org; Wed, 05 Dec 2018 15:38:28 -0500 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Thu, 6 Dec 2018 00:37:35 +0400 Message-Id: <20181205203737.9011-6-marcandre.lureau@redhat.com> In-Reply-To: <20181205203737.9011-1-marcandre.lureau@redhat.com> References: <20181205203737.9011-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Zhang Chen , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , peterx@redhat.com, Jason Wang , Li Zhijian , Markus Armbruster , "Dr. David Alan Gilbert" COLO uses a worker context (iothread) to drive the chardev. All backends are not able to switch the context, let's report an error in this case. Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/colo-compare.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/colo-compare.c b/net/colo-compare.c index a39191d522..9156ab3349 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr, return 1; } =20 + if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) { + error_setg(errp, "chardev \"%s\" cannot switch context", + chr_name); + return 1; + } + return 0; } =20 --=20 2.20.0.rc1