qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luc Michel <luc.michel@greensocs.com>
To: qemu-devel@nongnu.org
Cc: "Luc Michel" <luc.michel@greensocs.com>,
	qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	saipava@xilinx.com, edgari@xilinx.com, alistair@alistair23.me,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	mark.burton@greensocs.com,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [Qemu-devel] [PATCH v8 12/16] gdbstub: add support for vAttach packets
Date: Fri,  7 Dec 2018 10:01:30 +0100	[thread overview]
Message-ID: <20181207090135.7651-13-luc.michel@greensocs.com> (raw)
In-Reply-To: <20181207090135.7651-1-luc.michel@greensocs.com>

Add support for the vAttach packets. In multiprocess mode, GDB sends
them to attach to additional processes.

Signed-off-by: Luc Michel <luc.michel@greensocs.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 gdbstub.c | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gdbstub.c b/gdbstub.c
index 1cf1bea428..8601be533b 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1347,10 +1347,45 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
                     break;
                 }
                 goto unknown_command;
             }
             break;
+        } else if (strncmp(p, "Attach;", 7) == 0) {
+            unsigned long pid;
+
+            p += 7;
+
+            if (qemu_strtoul(p, &p, 16, &pid)) {
+                put_packet(s, "E22");
+                break;
+            }
+
+            process = gdb_get_process(s, pid);
+
+            if (process == NULL) {
+                put_packet(s, "E22");
+                break;
+            }
+
+            cpu = get_first_cpu_in_process(s, process);
+
+            if (cpu == NULL) {
+                /* Refuse to attach an empty process */
+                put_packet(s, "E22");
+                break;
+            }
+
+            process->attached = true;
+
+            s->g_cpu = cpu;
+            s->c_cpu = cpu;
+
+            snprintf(buf, sizeof(buf), "T%02xthread:%s;", GDB_SIGNAL_TRAP,
+                     gdb_fmt_thread_id(s, cpu, thread_id, sizeof(thread_id)));
+
+            put_packet(s, buf);
+            break;
         } else {
             goto unknown_command;
         }
     case 'k':
         /* Kill the target */
-- 
2.19.2

  parent reply	other threads:[~2018-12-07  9:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  9:01 [Qemu-devel] [PATCH v8 00/16] gdbstub: support for the multiprocess extension Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 01/16] hw/cpu: introduce CPU clusters Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 02/16] gdbstub: introduce GDB processes Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 03/16] gdbstub: add multiprocess support to '?' packets Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 04/16] gdbstub: add multiprocess support to 'H' and 'T' packets Luc Michel
2018-12-08  0:55   ` Alistair Francis
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 05/16] gdbstub: add multiprocess support to vCont packets Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 06/16] gdbstub: add multiprocess support to 'sC' packets Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 07/16] gdbstub: add multiprocess support to (f|s)ThreadInfo and ThreadExtraInfo Luc Michel
2018-12-12 17:35   ` Alistair Francis
2019-01-29  4:56   ` Max Filippov
2019-01-29 10:05     ` Peter Maydell
2019-01-29 20:25       ` Max Filippov
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 08/16] gdbstub: add multiprocess support to Xfer:features:read: Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 09/16] gdbstub: add multiprocess support to gdb_vm_state_change() Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 10/16] gdbstub: add multiprocess support to 'D' packets Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 11/16] gdbstub: add support for extended mode packet Luc Michel
2018-12-07  9:01 ` Luc Michel [this message]
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 13/16] gdbstub: processes initialization on new peer connection Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 15/16] gdbstub: add multiprocess extension support Luc Michel
2018-12-07  9:01 ` [Qemu-devel] [PATCH v8 16/16] arm/xlnx-zynqmp: put APUs and RPUs in separate CPU clusters Luc Michel
2018-12-17  8:23 ` [Qemu-devel] [PATCH v8 00/16] gdbstub: support for the multiprocess extension Luc Michel
2018-12-17 12:43   ` Peter Maydell
2019-01-04 15:12 ` Peter Maydell
2019-01-07  8:56   ` Luc Michel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207090135.7651-13-luc.michel@greensocs.com \
    --to=luc.michel@greensocs.com \
    --cc=alistair@alistair23.me \
    --cc=edgari@xilinx.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=mark.burton@greensocs.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=saipava@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).