From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gVDJE-0007Ug-Ev for qemu-devel@nongnu.org; Fri, 07 Dec 2018 05:24:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gVDJD-0000Zs-Mv for qemu-devel@nongnu.org; Fri, 07 Dec 2018 05:24:36 -0500 Date: Fri, 7 Dec 2018 11:24:25 +0100 From: Kevin Wolf Message-ID: <20181207102425.GA5119@linux.fritz.box> References: <20181206151304.8388-1-kwolf@redhat.com> <20181206151304.8388-2-kwolf@redhat.com> <871s6t4z65.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871s6t4z65.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v3 1/4] vmdk: Refactor vmdk_create_extent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com Am 07.12.2018 um 07:40 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > From: Fam Zheng > > > > The extracted vmdk_init_extent takes a BlockBackend object and > > initializes the format metadata. It is the common part between "qemu-img > > create" and "blockdev-create". > > > > Add a "BlockBackend *pbb" parameter to vmdk_create_extent, to return the > > opened BB to the caller in the next patch. > > I'd do this part in the next patch, when it has a user. Matter of > taste. I kept Fam as the author of the patches (except for the test case which is effectively a rewrite with Fam's test as the spec), so I'd like to do only the minimal editing necessary to make the patches mergeable. If it's a matter of taste, I'll leave it as it is. The same goes for code changes that are a matter of taste: If you _really_ care about taste in the vmdk code, feel free to send a follow-up and I'll merge it on top, but I'll leave Fam's patches alone as much as I can. > Reviewed-by: Markus Armbruster Thanks! Kevin