qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	xen-devel@lists.xenproject.org, Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v2 09/18] xen: remove unnecessary code from dataplane/xen-block.c
Date: Fri, 7 Dec 2018 16:20:19 +0000	[thread overview]
Message-ID: <20181207162019.GA29831@perard.uk.xensource.com> (raw)
In-Reply-To: <1544108924-10841-10-git-send-email-paul.durrant@citrix.com>

On Thu, Dec 06, 2018 at 03:08:35PM +0000, Paul Durrant wrote:
> v2:
>  - Leave existing boilerplate alone, other than removing the now-incorrect
>    description
> ---
>  hw/block/dataplane/xen-block.c | 409 ++---------------------------------------
>  1 file changed, 16 insertions(+), 393 deletions(-)
> 
> diff --git a/hw/block/dataplane/xen-block.c b/hw/block/dataplane/xen-block.c
> index 9fae505..98f987d 100644
> --- a/hw/block/dataplane/xen-block.c
> +++ b/hw/block/dataplane/xen-block.c
> @@ -1,6 +1,4 @@
>  /*
> - *  xen paravirt block device backend
> - *
>   *  (c) Gerd Hoffmann <kraxel@redhat.com>
>   *
>   *  This program is free software; you can redistribute it and/or modify
> @@ -19,26 +17,12 @@
>   *  GNU GPL, version 2 or (at your option) any later version.
>   */
>  
> +/*
> + * Copyright (c) 2018  Citrix Systems Inc.

You can add this copyright line just after Gerd's one abrove.

> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.

And I'm pretty sure this should not be added. The boilerplate at the top
of the file already state that your contributions is going to be GPLv2+.

-- 
Anthony PERARD

  reply	other threads:[~2018-12-07 16:20 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 15:08 [Qemu-devel] [PATCH v2 00/18] Xen PV backend 'qdevification' Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 01/18] xen: re-name XenDevice to XenLegacyDevice Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy Paul Durrant
2018-12-07 12:15   ` Anthony PERARD
2018-12-07 12:57     ` Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom' Paul Durrant
2018-12-07 14:35   ` Anthony PERARD
2018-12-07 14:39     ` Paul Durrant
2018-12-07 15:26       ` Anthony PERARD
2018-12-07 15:34         ` Daniel P. Berrangé
2018-12-10  9:35         ` Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 04/18] xen: create xenstore areas for XenDevice-s Paul Durrant
2018-12-07 15:07   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 05/18] xen: add xenstore watcher infrastructure Paul Durrant
2018-12-07 15:57   ` Anthony PERARD
2018-12-10  9:43     ` Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 06/18] xen: add grant table interface for XenDevice-s Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 07/18] xen: add event channel " Paul Durrant
2018-12-07 16:03   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 09/18] xen: remove unnecessary code from dataplane/xen-block.c Paul Durrant
2018-12-07 16:20   ` Anthony PERARD [this message]
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 10/18] xen: add header and build dataplane/xen-block.c Paul Durrant
2018-12-07 16:48   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-block Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-block.c Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-block.c Paul Durrant
2018-12-07 16:52   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 14/18] xen: add implementations of xen-block connect and disconnect functions Paul Durrant
2018-12-07 18:20   ` Anthony PERARD
2018-12-08 11:31     ` Paul Durrant
2018-12-10 16:07     ` Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 15/18] xen: add a mechanism to automatically create XenDevice-s Paul Durrant
2018-12-07 18:30   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 16/18] xen: automatically create XenBlockDevice-s Paul Durrant
2018-12-07 18:52   ` Anthony PERARD
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 17/18] MAINTAINERS: add myself as a Xen maintainer Paul Durrant
2018-12-06 15:08 ` [Qemu-devel] [PATCH v2 18/18] xen: remove the legacy 'xen_disk' backend Paul Durrant
2018-12-07 18:52   ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207162019.GA29831@perard.uk.xensource.com \
    --to=anthony.perard@citrix.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=paul.durrant@citrix.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).