From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Corey Minyard <minyard@acm.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h"
Date: Fri, 7 Dec 2018 17:51:01 +0100 [thread overview]
Message-ID: <20181207165103.3992-3-philmd@redhat.com> (raw)
In-Reply-To: <20181207165103.3992-1-philmd@redhat.com>
All the consumers of "smbios_ipmi.h" are located in hw/smbios/.
There is no need to have this include publicly exposed,
reduce the visibility by moving it in hw/smbios/.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/smbios/smbios.c | 2 +-
include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h | 0
hw/smbios/smbios_type_38-stub.c | 2 +-
hw/smbios/smbios_type_38.c | 2 +-
4 files changed, 3 insertions(+), 3 deletions(-)
rename include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h (100%)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 920939454e..30bd4731cf 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -28,7 +28,7 @@
#include "hw/loader.h"
#include "exec/cpu-common.h"
#include "smbios_build.h"
-#include "hw/smbios/ipmi.h"
+#include "smbios_ipmi.h"
/* legacy structures and constants for <= 2.0 machines */
struct smbios_header {
diff --git a/include/hw/smbios/ipmi.h b/hw/smbios/smbios_ipmi.h
similarity index 100%
rename from include/hw/smbios/ipmi.h
rename to hw/smbios/smbios_ipmi.h
diff --git a/hw/smbios/smbios_type_38-stub.c b/hw/smbios/smbios_type_38-stub.c
index 5b83c9b1f1..fc4516bc8a 100644
--- a/hw/smbios/smbios_type_38-stub.c
+++ b/hw/smbios/smbios_type_38-stub.c
@@ -8,7 +8,7 @@
*/
#include "qemu/osdep.h"
-#include "hw/smbios/ipmi.h"
+#include "smbios_ipmi.h"
void smbios_build_type_38_table(void)
{
diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c
index 56e8609c00..d84e87d608 100644
--- a/hw/smbios/smbios_type_38.c
+++ b/hw/smbios/smbios_type_38.c
@@ -9,10 +9,10 @@
#include "qemu/osdep.h"
#include "hw/ipmi/ipmi.h"
-#include "hw/smbios/ipmi.h"
#include "hw/smbios/smbios.h"
#include "qemu/error-report.h"
#include "smbios_build.h"
+#include "smbios_ipmi.h"
/* SMBIOS type 38 - IPMI */
struct smbios_type_38 {
--
2.17.2
next prev parent reply other threads:[~2018-12-07 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 16:50 [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace Philippe Mathieu-Daudé
2018-12-07 16:51 ` [Qemu-devel] [PATCH 1/4] tests: Remove unused include Philippe Mathieu-Daudé
2018-12-10 14:55 ` Laszlo Ersek
2018-12-10 15:51 ` Philippe Mathieu-Daudé
2018-12-07 16:51 ` Philippe Mathieu-Daudé [this message]
2018-12-10 15:00 ` [Qemu-devel] [PATCH 2/4] hw/smbios: Restrict access to "smbios_ipmi.h" Laszlo Ersek
2018-12-10 15:53 ` Philippe Mathieu-Daudé
2018-12-07 16:51 ` [Qemu-devel] [PATCH 3/4] hw/smbios: Remove "smbios_ipmi.h" Philippe Mathieu-Daudé
2018-12-07 17:13 ` Corey Minyard
2018-12-10 15:04 ` Laszlo Ersek
2018-12-07 16:51 ` [Qemu-devel] [PATCH 4/4] hw/smbios: Move to the hw/firmware/ namespace Philippe Mathieu-Daudé
2018-12-10 15:10 ` Laszlo Ersek
2018-12-10 15:57 ` Philippe Mathieu-Daudé
2018-12-07 17:36 ` [Qemu-devel] [PATCH 0/4] Introduce " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207165103.3992-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).