From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH 1/8] qemu/queue.h: do not access tqe_prev directly
Date: Mon, 10 Dec 2018 19:28:09 +0100 [thread overview]
Message-ID: <20181210182816.2014-2-pbonzini@redhat.com> (raw)
In-Reply-To: <20181210182816.2014-1-pbonzini@redhat.com>
Use the QTAILQ_IN_USE macro instead, it does the same thing but in a
few patches its definition will change.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index 81f95d920b..7604b2183b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -4259,7 +4259,7 @@ void qmp_blockdev_del(const char *node_name, Error **errp)
goto out;
}
- if (!bs->monitor_list.tqe_prev) {
+ if (!QTAILQ_IN_USE(bs, monitor_list)) {
error_setg(errp, "Node %s is not owned by the monitor",
bs->node_name);
goto out;
--
2.19.2
next prev parent reply other threads:[~2018-12-10 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:28 [Qemu-devel] [PATCH for-4.0 v2 0/8] qemu/queue.h usage cleanup, improved QTAILQ API Paolo Bonzini
2018-12-10 18:28 ` Paolo Bonzini [this message]
2018-12-10 18:28 ` [Qemu-devel] [PATCH 2/8] vfio: make vfio_address_spaces static Paolo Bonzini
2018-12-10 21:23 ` Alex Williamson
2018-12-10 18:28 ` [Qemu-devel] [PATCH 3/8] qemu/queue.h: leave head structs anonymous unless necessary Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 4/8] qemu/queue.h: typedef QTAILQ heads Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 5/8] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY} Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 6/8] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 7/8] qemu/queue.h: simplify reverse access to QTAILQ Paolo Bonzini
2019-02-04 11:45 ` [Qemu-devel] valgrind errors (was: [PATCH 7/8] qemu/queue.h: simplify reverse access to QTAILQ) Thomas Huth
2019-02-04 15:35 ` Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 8/8] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210182816.2014-2-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).