From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, Alex Williamson <alex.williamson@redhat.com>
Subject: [Qemu-devel] [PATCH 2/8] vfio: make vfio_address_spaces static
Date: Mon, 10 Dec 2018 19:28:10 +0100 [thread overview]
Message-ID: <20181210182816.2014-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20181210182816.2014-1-pbonzini@redhat.com>
It is not used outside hw/vfio/common.c, so it does not need to
be extern.
Cc: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/vfio/common.c | 2 +-
include/hw/vfio/vfio-common.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 7c185e5a2e..7aa804ea0b 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -39,7 +39,7 @@
struct vfio_group_head vfio_group_list =
QLIST_HEAD_INITIALIZER(vfio_group_list);
-struct vfio_as_head vfio_address_spaces =
+static QLIST_HEAD(, VFIOAddressSpace) vfio_address_spaces =
QLIST_HEAD_INITIALIZER(vfio_address_spaces);
#ifdef CONFIG_KVM
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index 1b434d02f6..127ca47815 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -181,7 +181,6 @@ int vfio_get_device(VFIOGroup *group, const char *name,
extern const MemoryRegionOps vfio_region_ops;
extern QLIST_HEAD(vfio_group_head, VFIOGroup) vfio_group_list;
-extern QLIST_HEAD(vfio_as_head, VFIOAddressSpace) vfio_address_spaces;
#ifdef CONFIG_LINUX
int vfio_get_region_info(VFIODevice *vbasedev, int index,
--
2.19.2
next prev parent reply other threads:[~2018-12-10 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:28 [Qemu-devel] [PATCH for-4.0 v2 0/8] qemu/queue.h usage cleanup, improved QTAILQ API Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 1/8] qemu/queue.h: do not access tqe_prev directly Paolo Bonzini
2018-12-10 18:28 ` Paolo Bonzini [this message]
2018-12-10 21:23 ` [Qemu-devel] [PATCH 2/8] vfio: make vfio_address_spaces static Alex Williamson
2018-12-10 18:28 ` [Qemu-devel] [PATCH 3/8] qemu/queue.h: leave head structs anonymous unless necessary Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 4/8] qemu/queue.h: typedef QTAILQ heads Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 5/8] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY} Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 6/8] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 7/8] qemu/queue.h: simplify reverse access to QTAILQ Paolo Bonzini
2019-02-04 11:45 ` [Qemu-devel] valgrind errors (was: [PATCH 7/8] qemu/queue.h: simplify reverse access to QTAILQ) Thomas Huth
2019-02-04 15:35 ` Paolo Bonzini
2018-12-10 18:28 ` [Qemu-devel] [PATCH 8/8] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210182816.2014-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).