qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: "Alexey Kardashevskiy" <aik@ozlabs.ru>,
	qemu-ppc@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>,
	"Greg Kurz" <groug@kaod.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH qemu 1/3] configure/fdt: Use more strict test for libfdt version
Date: Tue, 11 Dec 2018 16:49:24 +1100	[thread overview]
Message-ID: <20181211054926.56717-2-aik@ozlabs.ru> (raw)
In-Reply-To: <20181211054926.56717-1-aik@ozlabs.ru>

The libfdt installed in the system is preferred to the dtc submodule by
default. The recent libfdt update added a new symbol - fdt_check_full -
and this breaks compile if there is an older libfdt installed in
the system.

This changes the test to force ./configure into using newer libfdt.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 0a3c6a7..e5312da 100755
--- a/configure
+++ b/configure
@@ -3880,7 +3880,7 @@ if test "$fdt" != "no" ; then
   cat > $TMPC << EOF
 #include <libfdt.h>
 #include <libfdt_env.h>
-int main(void) { fdt_first_subnode(0, 0); return 0; }
+int main(void) { fdt_check_full(NULL, 0); return 0; }
 EOF
   if compile_prog "" "$fdt_libs" ; then
     # system DTC is good - use it
-- 
2.17.1

  reply	other threads:[~2018-12-11  5:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  5:49 [Qemu-devel] [PATCH qemu 0/3] ppc/spapr: Receive and store device tree blob from SLOF Alexey Kardashevskiy
2018-12-11  5:49 ` Alexey Kardashevskiy [this message]
2018-12-11  9:31   ` [Qemu-devel] [PATCH qemu 1/3] configure/fdt: Use more strict test for libfdt version Daniel P. Berrangé
2018-12-11 16:16   ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-12-11  5:49 ` [Qemu-devel] [PATCH qemu 2/3] ppc/spapr: Receive and store device tree blob from SLOF Alexey Kardashevskiy
2018-12-11 16:35   ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-12-11 23:57     ` Alexey Kardashevskiy
2018-12-12  9:46       ` Greg Kurz
2018-12-13  2:53         ` Alexey Kardashevskiy
2018-12-13  7:59           ` Greg Kurz
2018-12-11  5:49 ` [Qemu-devel] [PATCH qemu 3/3] spapr: Fix fdt warnings Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211054926.56717-2-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).