qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lindsay <aaron@os.amperecomputing.com>
To: "qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair.francis@xilinx.com>,
	Wei Huang <wei@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <richard.henderson@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Michael Spradling <mspradli@codeaurora.org>,
	Digant Desai <digantd@codeaurora.org>,
	Aaron Lindsay <aaron@os.amperecomputing.com>,
	Aaron Lindsay <alindsay@codeaurora.org>
Subject: [Qemu-devel] [PATCH v10 06/14] target/arm: Implement PMOVSSET
Date: Tue, 11 Dec 2018 15:20:29 +0000	[thread overview]
Message-ID: <20181211151945.29137-7-aaron@os.amperecomputing.com> (raw)
In-Reply-To: <20181211151945.29137-1-aaron@os.amperecomputing.com>

Add an array for PMOVSSET so we only define it for v7ve+ platforms

Signed-off-by: Aaron Lindsay <alindsay@codeaurora.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/helper.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 0aff261528..71be6fb578 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -1342,6 +1342,13 @@ static void pmovsr_write(CPUARMState *env, const ARMCPRegInfo *ri,
     env->cp15.c9_pmovsr &= ~value;
 }
 
+static void pmovsset_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                         uint64_t value)
+{
+    value &= pmu_counter_mask(env);
+    env->cp15.c9_pmovsr |= value;
+}
+
 static void pmxevtyper_write(CPUARMState *env, const ARMCPRegInfo *ri,
                              uint64_t value)
 {
@@ -1709,6 +1716,24 @@ static const ARMCPRegInfo v7mp_cp_reginfo[] = {
     REGINFO_SENTINEL
 };
 
+static const ARMCPRegInfo pmovsset_cp_reginfo[] = {
+    /* PMOVSSET is not implemented in v7 before v7ve */
+    { .name = "PMOVSSET", .cp = 15, .opc1 = 0, .crn = 9, .crm = 14, .opc2 = 3,
+      .access = PL0_RW, .accessfn = pmreg_access,
+      .type = ARM_CP_ALIAS,
+      .fieldoffset = offsetoflow32(CPUARMState, cp15.c9_pmovsr),
+      .writefn = pmovsset_write,
+      .raw_writefn = raw_write },
+    { .name = "PMOVSSET_EL0", .state = ARM_CP_STATE_AA64,
+      .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 14, .opc2 = 3,
+      .access = PL0_RW, .accessfn = pmreg_access,
+      .type = ARM_CP_ALIAS,
+      .fieldoffset = offsetof(CPUARMState, cp15.c9_pmovsr),
+      .writefn = pmovsset_write,
+      .raw_writefn = raw_write },
+    REGINFO_SENTINEL
+};
+
 static void teecr_write(CPUARMState *env, const ARMCPRegInfo *ri,
                         uint64_t value)
 {
@@ -5191,6 +5216,9 @@ void register_cp_regs_for_features(ARMCPU *cpu)
         !arm_feature(env, ARM_FEATURE_PMSA)) {
         define_arm_cp_regs(cpu, v7mp_cp_reginfo);
     }
+    if (arm_feature(env, ARM_FEATURE_V7VE)) {
+        define_arm_cp_regs(cpu, pmovsset_cp_reginfo);
+    }
     if (arm_feature(env, ARM_FEATURE_V7)) {
         /* v7 performance monitor control register: same implementor
          * field as main ID register, and we implement only the cycle
-- 
2.19.2

  parent reply	other threads:[~2018-12-11 15:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 15:20 [Qemu-devel] [PATCH v10 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 01/14] migration: Add post_save function to VMStateDescription Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 02/14] target/arm: Reorganize PMCCNTR accesses Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 03/14] target/arm: Swap PMU values before/after migrations Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 04/14] target/arm: Filter cycle counter based on PMCCFILTR_EL0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 05/14] target/arm: Allow AArch32 access for PMCCFILTR Aaron Lindsay
2018-12-11 15:20 ` Aaron Lindsay [this message]
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 07/14] target/arm: Define FIELDs for ID_DFR0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 08/14] target/arm: Make PMCEID[01]_EL0 64 bit registers, add PMCEID[23] Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 09/14] target/arm: Add array for supported PMU events, generate PMCEID[01]_EL0 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 10/14] target/arm: Finish implementation of PM[X]EVCNTR and PM[X]EVTYPER Aaron Lindsay
2019-02-04 19:22   ` [Qemu-devel] [Qemu-arm] " Laurent Desnogues
2019-02-05 13:41     ` Aaron Lindsay OS
2019-02-05 13:54       ` Laurent Desnogues
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 11/14] target/arm: PMU: Add instruction and cycle events Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 12/14] target/arm: PMU: Set PMCR.N to 4 Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 13/14] target/arm: Implement PMSWINC Aaron Lindsay
2018-12-11 15:20 ` [Qemu-devel] [PATCH v10 14/14] target/arm: Send interrupts on PMU counter overflow Aaron Lindsay
2019-01-17 20:26   ` Richard Henderson
2019-01-18 21:40     ` Aaron Lindsay
2019-01-18 21:58       ` Richard Henderson
2019-01-11 16:22 ` [Qemu-devel] [PATCH v10 00/14] More fully implement ARM PMUv3 Aaron Lindsay
2019-01-18 14:13 ` Peter Maydell
2019-01-23 20:04   ` Aaron Lindsay OS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211151945.29137-7-aaron@os.amperecomputing.com \
    --to=aaron@os.amperecomputing.com \
    --cc=alindsay@codeaurora.org \
    --cc=alistair.francis@xilinx.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=digantd@codeaurora.org \
    --cc=mspradli@codeaurora.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).