From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWkuU-0006rn-01 for qemu-devel@nongnu.org; Tue, 11 Dec 2018 11:29:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWkuP-0003lL-RD for qemu-devel@nongnu.org; Tue, 11 Dec 2018 11:29:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57560) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWkuP-0003jL-DK for qemu-devel@nongnu.org; Tue, 11 Dec 2018 11:29:21 -0500 From: Wainer dos Santos Moschetta Date: Tue, 11 Dec 2018 11:28:46 -0500 Message-Id: <20181211162846.31149-1-wainersm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2] target/i386: Fixes to the check missing features routine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, eblake@redhat.com, crosa@redhat.com, ccarrara@redhat.com, Wainer dos Santos Moschetta The x86_cpu_class_check_missing_features() returns a list of unavailable features compared to the host CPU. Currently it may return empty strings for unnamed features as well as duplicated names. For example, the qmp "query-cpu-definitions" below shows one empty string and repeated "mpx" entries: (...) {"execute": "query-cpu-definitions"} (...) { "name": "Cascadelake-Server", "typename": "Cascadelake-Server-x86_64-cpu", "unavailable-features": [ "hle", "rtm", "mpx", "avx512f", "avx512dq", "rdseed", "adx", "smap", "clflushopt", "clwb", "intel-pt", "avx512cd", "avx512bw", "avx512vl", "pku", "", "avx512vnni", "spec-ctrl", "ssbd", "3dnowprefetch", "xsavec", "xgetbv1", "mpx", "mpx", "avx512f", "avx512f", "avx512f", "pku" ], (...) Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Eduardo Habkost Reviewed-by: Eric Blake Reviewed-by: Caio Carrara --- v2: * Fixed typos. [eblake] * Removed unwanted manual test case. [ccarrara, ehabkost] * Not passing 'accel=3Dkvm' on test's VM. [ehabkost] * Removed unneeded g_strdup() call. [ehabkost] * Formatted comment according to QEMU's coding style. [ehabkost] v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg579404.html --- target/i386/cpu.c | 11 ++++++++- tests/acceptance/cpu_definitions.py | 35 +++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 tests/acceptance/cpu_definitions.py diff --git a/target/i386/cpu.c b/target/i386/cpu.c index f81d35e1f9..014b91e608 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -3615,19 +3615,28 @@ static void x86_cpu_class_check_missing_features(= X86CPUClass *xcc, =20 x86_cpu_filter_features(xc); =20 + /* Auxiliary dictionary to avoid duplicate entries in the list. */ + QDict *unique_feats_dict =3D qdict_new(); + for (w =3D 0; w < FEATURE_WORDS; w++) { uint32_t filtered =3D xc->filtered_features[w]; int i; for (i =3D 0; i < 32; i++) { if (filtered & (1UL << i)) { + const char *fname =3D x86_cpu_feature_name(w, i); + if (!fname || qdict_haskey(unique_feats_dict, fname)) { + continue; + } strList *new =3D g_new0(strList, 1); - new->value =3D g_strdup(x86_cpu_feature_name(w, i)); + new->value =3D g_strdup(fname); *next =3D new; next =3D &new->next; + qdict_put_null(unique_feats_dict, new->value); } } } =20 + g_free(unique_feats_dict); object_unref(OBJECT(xc)); } =20 diff --git a/tests/acceptance/cpu_definitions.py b/tests/acceptance/cpu_d= efinitions.py new file mode 100644 index 0000000000..4edad86799 --- /dev/null +++ b/tests/acceptance/cpu_definitions.py @@ -0,0 +1,35 @@ +# CPU definitions tests. +# +# Copyright (c) 2018 Red Hat, Inc. +# +# Author: +# Wainer dos Santos Moschetta +# +# This work is licensed under the terms of the GNU GPL, version 2 or +# later. See the COPYING file in the top-level directory. + +from avocado import skip +from avocado_qemu import Test + + +class CPUDefinitions(Test): + """ + Tests for the CPU definitions. + + :avocado: enable + :avocado: tags=3Dx86_64 + """ + def test_unavailable_features(self): + self.vm.add_args("-machine", "q35") + self.vm.launch() + cpu_definitions =3D self.vm.command('query-cpu-definitions') + self.assertTrue(len(cpu_definitions) > 0) + for cpu_model in cpu_definitions: + name =3D cpu_model.get('name') + unavailable_features =3D cpu_model.get('unavailable-features= ') + + self.assertNotIn("", unavailable_features, + name + " has unamed feature") + self.assertEqual(len(unavailable_features), + len(set(unavailable_features)), + name + " has duplicate feature") --=20 2.19.1