From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWp5Y-0006Fl-Va for qemu-devel@nongnu.org; Tue, 11 Dec 2018 15:57:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWp5V-0003k6-JE for qemu-devel@nongnu.org; Tue, 11 Dec 2018 15:57:08 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWp5V-0003jN-8n for qemu-devel@nongnu.org; Tue, 11 Dec 2018 15:57:05 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id wBBKsMh0102979 for ; Tue, 11 Dec 2018 15:57:04 -0500 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0a-001b2d01.pphosted.com with ESMTP id 2pam6r1ghw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 11 Dec 2018 15:57:03 -0500 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 11 Dec 2018 20:57:02 -0000 From: Stefan Berger Date: Tue, 11 Dec 2018 15:56:54 -0500 In-Reply-To: <20181211205654.3550341-1-stefanb@linux.vnet.ibm.com> References: <20181211205654.3550341-1-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Message-Id: <20181211205654.3550341-4-stefanb@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL v2 3/3] tpm: Make sure the locality received from backend is valid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Stefan Berger , Stefan Berger Make sure that the locality passed from the backend to tpm_tis_request_completed() is valid. Signed-off-by: Stefan Berger Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/tpm/tpm_tis.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 04e4ad9212..2563d7501f 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -295,6 +295,8 @@ static void tpm_tis_request_completed(TPMIf *ti, int = ret) uint8_t locty =3D s->cmd.locty; uint8_t l; =20 + assert(TPM_TIS_IS_VALID_LOCTY(locty)); + if (s->cmd.selftest_done) { for (l =3D 0; l < TPM_TIS_NUM_LOCALITIES; l++) { s->loc[l].sts |=3D TPM_TIS_STS_SELFTEST_DONE; --=20 2.17.1