From: Kevin Wolf <kwolf@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Tim Smith <tim.smith@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org, armbru@redhat.com, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Paul Durrant <Paul.Durrant@citrix.com>,
Anthony Perard <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2)
Date: Wed, 12 Dec 2018 13:03:22 +0100 [thread overview]
Message-ID: <20181212120322.GA5415@linux.fritz.box> (raw)
In-Reply-To: <20181212085951.GA7604@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 753 bytes --]
Am 12.12.2018 um 09:59 hat Olaf Hering geschrieben:
> On Fri, Nov 02, Kevin Wolf wrote:
>
> > A while ago, a downstream patch review found out that there are some QMP
> > commands that would immediately crash if a xen_disk device were present
> > because of the lacking qdevification. This is not the code quality
> > standard I envision for QEMU. It's time for non-qdev devices to go.
>
> Do you have that backwards by any chance? IMO the presence of assert()
> contributes to bad code quality, not the drivers that trigger those
> asserts.
You like shooting the messenger, it seems? Bugs aren't bad, only
catching them is?
But anyway, in this case, I seem to remember it was a plain old
segfault, not a failed assertion.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-12-12 12:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 10:00 [Qemu-devel] [PATCH 0/3] Performance improvements for xen_disk v2 Tim Smith
2018-11-02 10:00 ` [Qemu-devel] [PATCH 1/3] Improve xen_disk batching behaviour Tim Smith
2018-11-02 11:14 ` Paul Durrant
2018-11-02 13:53 ` Anthony PERARD
2018-11-02 10:01 ` [Qemu-devel] [PATCH 2/3] Improve xen_disk response latency Tim Smith
2018-11-02 11:14 ` Paul Durrant
2018-11-02 13:53 ` Anthony PERARD
2018-11-02 10:01 ` [Qemu-devel] [PATCH 3/3] Avoid repeated memory allocation in xen_disk Tim Smith
2018-11-02 11:15 ` Paul Durrant
2018-11-02 13:53 ` Anthony PERARD
2018-11-02 11:04 ` [Qemu-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2) Kevin Wolf
2018-11-02 11:13 ` Paul Durrant
2018-11-02 12:14 ` Kevin Wolf
2018-11-05 15:57 ` [Qemu-devel] xen_disk qdevification Markus Armbruster
2018-11-05 16:15 ` Paul Durrant
2018-11-08 14:00 ` Paul Durrant
2018-11-08 15:21 ` Kevin Wolf
2018-11-08 15:43 ` Paul Durrant
2018-11-08 16:44 ` Paul Durrant
2018-11-09 10:27 ` Paul Durrant
2018-11-09 10:40 ` Kevin Wolf
2018-12-12 8:59 ` [Qemu-devel] [Xen-devel] xen_disk qdevification (was: [PATCH 0/3] Performance improvements for xen_disk v2) Olaf Hering
2018-12-12 9:22 ` Paul Durrant
2018-12-12 12:03 ` Kevin Wolf [this message]
2018-12-12 12:04 ` [Qemu-devel] [Xen-devel] xen_disk qdevification Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212120322.GA5415@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=Paul.Durrant@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=mreitz@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=tim.smith@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).