From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX8LB-0006yX-IW for qemu-devel@nongnu.org; Wed, 12 Dec 2018 12:30:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX8L8-00018n-Vm for qemu-devel@nongnu.org; Wed, 12 Dec 2018 12:30:33 -0500 From: Laurent Vivier Date: Wed, 12 Dec 2018 18:30:02 +0100 Message-Id: <20181212173007.11407-2-lvivier@redhat.com> In-Reply-To: <20181212173007.11407-1-lvivier@redhat.com> References: <20181212173007.11407-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/6] hw/dma/puv3_dma: Convert from DPRINTF() macro to trace event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, Guan Xuetao , Michael Tokarev , Laurent Vivier Signed-off-by: Laurent Vivier --- hw/dma/puv3_dma.c | 11 +++++------ hw/dma/trace-events | 6 ++++++ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/dma/puv3_dma.c b/hw/dma/puv3_dma.c index b97a6c1767..38ebb3f307 100644 --- a/hw/dma/puv3_dma.c +++ b/hw/dma/puv3_dma.c @@ -11,9 +11,8 @@ #include "qemu/osdep.h" #include "hw/hw.h" #include "hw/sysbus.h" - -#undef DEBUG_PUV3 #include "hw/unicore32/puv3.h" +#include "trace.h" =20 #define PUV3_DMA_CH_NR (6) #define PUV3_DMA_CH_MASK (0xff) @@ -42,9 +41,9 @@ static uint64_t puv3_dma_read(void *opaque, hwaddr offs= et, ret =3D s->reg_CFG[PUV3_DMA_CH(offset)]; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + trace_puv3_dma_read_bad(offset); } - DPRINTF("offset 0x%x, value 0x%x\n", offset, ret); + trace_puv3_dma_read(offset, ret); =20 return ret; } @@ -61,9 +60,9 @@ static void puv3_dma_write(void *opaque, hwaddr offset, s->reg_CFG[PUV3_DMA_CH(offset)] =3D value; break; default: - DPRINTF("Bad offset 0x%x\n", offset); + trace_puv3_dma_write_bad(offset); } - DPRINTF("offset 0x%x, value 0x%x\n", offset, value); + trace_puv3_dma_write(offset, value); } =20 static const MemoryRegionOps puv3_dma_ops =3D { diff --git a/hw/dma/trace-events b/hw/dma/trace-events index 22f53d0ff2..56d4f5a32a 100644 --- a/hw/dma/trace-events +++ b/hw/dma/trace-events @@ -20,3 +20,9 @@ sparc32_dma_enable_lower(void) "Lower DMA enable" =20 # hw/dma/i8257.c i8257_unregistered_dma(int nchan, int dma_pos, int dma_len) "unregistere= d DMA channel used nchan=3D%d dma_pos=3D%d dma_len=3D%d" + +# hw/dma/puv3_dma.c +puv3_dma_read_bad(unsigned offset) "Bad offset 0x%x" +puv3_dma_read(unsigned offset, uint32_t value) "offset 0x%x, value 0x%x" +puv3_dma_write_bad(unsigned offset) "Bad offset 0x%x" +puv3_dma_write(unsigned offset, uint64_t value) "offset 0x%x, value 0x%"= PRIx64 --=20 2.19.2