From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-trivial@nongnu.org, "Guan Xuetao" <gxt@mprc.pku.edu.cn>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: [Qemu-devel] [PATCH 4/6] hw/misc/puv3_pm: Convert from DPRINTF() macro to trace event
Date: Wed, 12 Dec 2018 18:30:05 +0100 [thread overview]
Message-ID: <20181212173007.11407-5-lvivier@redhat.com> (raw)
In-Reply-To: <20181212173007.11407-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
hw/misc/puv3_pm.c | 11 +++++------
hw/misc/trace-events | 6 ++++++
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c
index 577cebaac7..4db7b1c22a 100644
--- a/hw/misc/puv3_pm.c
+++ b/hw/misc/puv3_pm.c
@@ -11,9 +11,8 @@
#include "qemu/osdep.h"
#include "hw/hw.h"
#include "hw/sysbus.h"
-
-#undef DEBUG_PUV3
#include "hw/unicore32/puv3.h"
+#include "trace.h"
#define TYPE_PUV3_PM "puv3_pm"
#define PUV3_PM(obj) OBJECT_CHECK(PUV3PMState, (obj), TYPE_PUV3_PM)
@@ -72,9 +71,9 @@ static uint64_t puv3_pm_read(void *opaque, hwaddr offset,
ret = 0x7;
break;
default:
- DPRINTF("Bad offset 0x%x\n", offset);
+ trace_puv3_pm_read_bad(offset);
}
- DPRINTF("offset 0x%x, value 0x%x\n", offset, ret);
+ trace_puv3_pm_read(offset, ret);
return ret;
}
@@ -104,9 +103,9 @@ static void puv3_pm_write(void *opaque, hwaddr offset,
case 0x38:
break;
default:
- DPRINTF("Bad offset 0x%x\n", offset);
+ trace_puv3_pm_write_bad(offset);
}
- DPRINTF("offset 0x%x, value 0x%x\n", offset, value);
+ trace_puv3_pm_write(offset, value);
}
static const MemoryRegionOps puv3_pm_ops = {
diff --git a/hw/misc/trace-events b/hw/misc/trace-events
index 52466c77c4..d17a52c91d 100644
--- a/hw/misc/trace-events
+++ b/hw/misc/trace-events
@@ -132,3 +132,9 @@ iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysI
iotkit_sysctl_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysCtl read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u"
iotkit_sysctl_write(uint64_t offset, uint64_t data, unsigned size) "IoTKit SysCtl write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u"
iotkit_sysctl_reset(void) "IoTKit SysCtl: reset"
+
+# hw/misc/puv3_pm.c
+puv3_pm_read_bad(uint32_t offset) "Bad offset 0x%x"
+puv3_pm_read(uint32_t offset, uint32_t value) "offset 0x%x, value 0x%x"
+puv3_pm_write_bad(uint32_t offset) "Bad offset 0x%x"
+puv3_pm_write(uint32_t offset, uint64_t value) "offset 0x%x, value 0x%" PRIx64
--
2.19.2
next prev parent reply other threads:[~2018-12-12 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 17:30 [Qemu-devel] [PATCH 0/6] unicore32/puv3: Convert from DPRINTF() macro to trace event Laurent Vivier
2018-12-12 17:30 ` [Qemu-devel] [PATCH 1/6] hw/dma/puv3_dma: " Laurent Vivier
2018-12-12 17:30 ` [Qemu-devel] [PATCH 2/6] hw/dma/puv3_gpio: " Laurent Vivier
2018-12-12 17:30 ` [Qemu-devel] [PATCH 3/6] hw/dma/puv3_intc: " Laurent Vivier
2018-12-12 17:30 ` Laurent Vivier [this message]
2018-12-12 17:30 ` [Qemu-devel] [PATCH 5/6] hw/timer/puv3_ost: " Laurent Vivier
2018-12-12 17:30 ` [Qemu-devel] [PATCH 6/6] unicore32/puv3: remove definition of DPRINTF Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212173007.11407-5-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=f4bug@amsat.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).