From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX8oJ-00062o-7N for qemu-devel@nongnu.org; Wed, 12 Dec 2018 13:00:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX8oE-0005ro-OP for qemu-devel@nongnu.org; Wed, 12 Dec 2018 13:00:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49480) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gX8oE-0005qD-Go for qemu-devel@nongnu.org; Wed, 12 Dec 2018 13:00:34 -0500 From: P J P Date: Wed, 12 Dec 2018 23:28:17 +0530 Message-Id: <20181212175817.815-1-ppandit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] pvrdma: release device resources in case of an error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuval Shaia Cc: Qemu Developers , Marcel Apfelbaum , Li Qiang , Prasad J Pandit From: Prasad J Pandit If during pvrdma device initialisation an error occurs, pvrdma_realize() does not release memory resources, leading to memory leakage. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/rdma/vmw/pvrdma_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 8a03ab4669..b65f8662df 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -579,7 +579,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, voi= d *opaque) =20 static void pvrdma_realize(PCIDevice *pdev, Error **errp) { - int rc; + int rc =3D 0; PVRDMADev *dev =3D PVRDMA_DEV(pdev); Object *memdev_root; bool ram_shared =3D false; @@ -655,6 +655,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **e= rrp) =20 out: if (rc) { + pvrdma_fini(pdev); error_append_hint(errp, "Device fail to load\n"); } } --=20 2.19.2