From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
stefanb@linux.vnet.ibm.com,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
f4bug@amsat.org, "Stefan Berger" <stefanb@linux.ibm.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v13 0/6] Add support for TPM Physical Presence interface
Date: Thu, 13 Dec 2018 02:26:42 +0400 [thread overview]
Message-ID: <20181212222648.595-1-marcandre.lureau@redhat.com> (raw)
Hi,
The following patches implement the TPM Physical Presence Interface
that allows a user to set a command via ACPI (sysfs entry in Linux)
that, upon the next reboot, the firmware looks for and acts upon by
sending sequences of commands to the TPM.
A dedicated memory region is added to the TPM CRB & TIS devices, at
address/size 0xFED45000/0x400. A new "etc/tpm/config" fw_cfg entry
holds the location for that PPI region and some version details, to
allow for future flexibility.
With the associated edk2/ovmf firmware, the Windows HLK "PPI 1.3" test
now runs successfully.
It is based on previous work from Stefan Berger ("[PATCH v2 0/4]
Implement Physical Presence interface for TPM 1.2 and 2")
The edk2 support is merged upstream.
v13:
- removed needless error handling in tpm_ppi_init()
- splitted "add ACPI memory clear interface"
- moved acpi build function in dedicated hw/acpi/tpm.c
- added some function documentation in headers
- various code cleanups suggested by Philippe
- rebased
Marc-André Lureau (3):
tpm: add a "ppi" boolean property
acpi: add ACPI memory clear interface
tpm: clear RAM when "memory overwrite" requested
Stefan Berger (3):
tpm: allocate/map buffer for TPM Physical Presence interface
acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg
acpi: build TPM Physical Presence interface
hw/tpm/tpm_ppi.h | 47 +++++
include/hw/acpi/tpm.h | 23 +++
include/hw/compat.h | 11 +-
hw/acpi/tpm.c | 447 ++++++++++++++++++++++++++++++++++++++++++
hw/i386/acpi-build.c | 29 ++-
hw/tpm/tpm_crb.c | 11 ++
hw/tpm/tpm_ppi.c | 53 +++++
hw/tpm/tpm_tis.c | 11 ++
docs/specs/tpm.txt | 104 ++++++++++
hw/acpi/Makefile.objs | 1 +
hw/tpm/Makefile.objs | 1 +
hw/tpm/trace-events | 3 +
12 files changed, 738 insertions(+), 3 deletions(-)
create mode 100644 hw/tpm/tpm_ppi.h
create mode 100644 hw/acpi/tpm.c
create mode 100644 hw/tpm/tpm_ppi.c
--
2.20.0
next reply other threads:[~2018-12-12 22:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 22:26 Marc-André Lureau [this message]
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 1/6] tpm: add a "ppi" boolean property Marc-André Lureau
2018-12-13 11:07 ` Philippe Mathieu-Daudé
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 2/6] tpm: allocate/map buffer for TPM Physical Presence interface Marc-André Lureau
2018-12-13 11:10 ` Philippe Mathieu-Daudé
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 3/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg Marc-André Lureau
2018-12-13 11:11 ` Philippe Mathieu-Daudé
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 4/6] acpi: build TPM Physical Presence interface Marc-André Lureau
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 5/6] acpi: add ACPI memory clear interface Marc-André Lureau
2018-12-12 22:26 ` [Qemu-devel] [PATCH v13 6/6] tpm: clear RAM when "memory overwrite" requested Marc-André Lureau
2018-12-13 11:17 ` Philippe Mathieu-Daudé
2018-12-18 1:37 ` [Qemu-devel] [PATCH v13 0/6] Add support for TPM Physical Presence interface Michael S. Tsirkin
2018-12-18 9:28 ` Marc-André Lureau
2018-12-18 14:20 ` Michael S. Tsirkin
2018-12-18 17:56 ` Marc-André Lureau
2018-12-18 23:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212222648.595-1-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).