From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXOnt-0001Qa-AW for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:05:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXOno-00063k-Hs for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:05:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXOno-00061D-AK for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:05:12 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C89BC2D7F7 for ; Thu, 13 Dec 2018 11:05:09 +0000 (UTC) Date: Thu, 13 Dec 2018 12:05:05 +0100 From: Kashyap Chamarthy Message-ID: <20181213110505.GL14101@paraplu> References: <20181030123526.26415-1-kchamart@redhat.com> <20181030123526.26415-2-kchamart@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 1/3] Deprecate QMP `cpu-add` List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, armbru@redhat.com, imammedo@redhat.com On Thu, Dec 13, 2018 at 07:38:03AM +0100, Thomas Huth wrote: > On 2018-10-30 13:35, Kashyap Chamarthy wrote: > > The intended functionality of QMP `cpu-add` is replaced with > > `device_add` (and `query-hotpluggable-cpus`). So let's deprecate > > `cpu-add`. > > > > A complete example of vCPU hotplug with the recommended way (using > > `device_add`) is provided as part of a seperate docs patch. > > > > Suggested-by: Eduardo Habkost > Signed-off-by: Kashyap Chamarthy > > --- > [...] > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > > index 1b9c007f12..c86924ad9a 100644 > > --- a/qemu-deprecated.texi > > +++ b/qemu-deprecated.texi > > @@ -155,6 +155,11 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. > > The ``arch'' output member of the ``query-cpus-fast'' command is > > replaced by the ``target'' output member. > > > > +@subsection cpu-add (since 3.1) > > Hi Kashyap, > > could you please send a follow-up patch to change this into 4.0 now? Ah, sure. > Please also provide a patch to add the HMP command to > qemu-deprecated.texi, too. Is it okay if both the above are done in the same patch? Since they're related. Or am I missing a reason to do them separately? -- /kashyap