From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXPho-0005jH-0K for qemu-devel@nongnu.org; Thu, 13 Dec 2018 07:03:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXPhj-0006FC-0b for qemu-devel@nongnu.org; Thu, 13 Dec 2018 07:03:03 -0500 Date: Thu, 13 Dec 2018 13:02:37 +0100 From: Kevin Wolf Message-ID: <20181213120237.GB5427@linux.fritz.box> References: <20181213112434.20039-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213112434.20039-1-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/mirror: add missing coroutine_fn annotations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Jeff Cody , qemu-block@nongnu.org, Max Reitz , John Snow Am 13.12.2018 um 12:24 hat Stefan Hajnoczi geschrieben: > Marking a function coroutine_fn currently has no effect on the compiler, > but it documents that this function must be called from coroutine > context and it may yield. This is important information for the > programmer. > > Also, if we ever transition to a stackless coroutine implementation, > then it's likely that the annotation will become mandatory so the > compiler can use the correct calling convention for coroutine functions. > > Cc: Max Reitz > Cc: John Snow > Signed-off-by: Stefan Hajnoczi Thanks, applied to the block branch. Kevin