From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXRsz-0007dJ-Ky for qemu-devel@nongnu.org; Thu, 13 Dec 2018 09:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXRst-0005QA-V4 for qemu-devel@nongnu.org; Thu, 13 Dec 2018 09:22:45 -0500 Date: Thu, 13 Dec 2018 15:22:10 +0100 From: Kevin Wolf Message-ID: <20181213142210.GE5427@linux.fritz.box> References: <20181212220410.569069-1-eblake@redhat.com> <20181213101154.GA5171@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20181213101154.GA5171@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Eric Blake , qemu-devel@nongnu.org, rjones@redhat.com, qemu-block@nongnu.org, Max Reitz Am 13.12.2018 um 11:11 hat Daniel P. Berrang=E9 geschrieben: > On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote: > > When a qemu-io command fails, it's best if the failure message > > goes to stderr rather than stdout. > >=20 > > Reported-by: Richard W.M. Jones > > Signed-off-by: Eric Blake > > --- > >=20 > > RFC because at least iotest 60 (found by -qcow2 -g quick) breaks due > > to reordering of output lines, and I'd rather know if we like this > > idea before bothering to revisit all affected iotests (including > > discovering if other slower ones have similar problems). >=20 > I think the change is correct. Error messages should never go to stdout= . I'm not sure about this, to be honest. qemu-io is first and foremost an interactive program, and spreading output across two streams, one buffered and one unbuffered, in an interactive program feels like it has to result in surprises. Kevin