From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, pbonzini@redhat.com, thuth@redhat.com,
ehabkost@redhat.com,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block
Date: Thu, 13 Dec 2018 12:55:51 -0500 [thread overview]
Message-ID: <20181213175552.14857-1-wainersm@redhat.com> (raw)
Eduardo Habkost pointed out a malformed block of comments on my
patch [1] that I had ran checkpatch.pl and no warn/error was
reported. Then I realized the script does not catch such as
case (or it had a bug).
It turns out that checkpatch.pl does not parse comment blocks (If I understood
its code correctly...). So I implemented a checker that warns about:
1. block doesn't begin on its own line.
Example:
/* blah blah
* and blah blah
*/
2. line in the block doesn't start with asterisk.
Example:
/*
foo bar
bar foo
*/
Note: only the first occurence (i.e 'foo bar') is reported.
3. block doesn't end on its own line.
Example:
/*
* blah blah
* and blah */
References:
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg580091.html
ps: last time I wrote Perl code was about 13 years ago. That remember me
of good times. :)
Wainer dos Santos Moschetta (1):
checkpatch: check for malformed comment block.
scripts/checkpatch.pl | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
--
2.19.1
next reply other threads:[~2018-12-13 17:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 17:55 Wainer dos Santos Moschetta [this message]
2018-12-13 17:55 ` [Qemu-devel] [PATCH 1/1] checkpatch: check for malformed comment block Wainer dos Santos Moschetta
2018-12-13 18:01 ` [Qemu-devel] [PATCH 0/1] checkpatch: checker for " Peter Maydell
2018-12-13 18:07 ` Paolo Bonzini
2018-12-13 18:21 ` Peter Maydell
2018-12-13 22:23 ` Paolo Bonzini
2018-12-14 6:29 ` Markus Armbruster
2018-12-14 9:32 ` Paolo Bonzini
2018-12-14 11:20 ` Peter Maydell
2018-12-14 12:31 ` Markus Armbruster
2018-12-14 12:57 ` Peter Maydell
2018-12-14 16:11 ` Markus Armbruster
2018-12-14 12:13 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213175552.14857-1-wainersm@redhat.com \
--to=wainersm@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).