Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them.  Change
> them to spaces so that we don't confuse people.
> 
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted from the check.
> Outside those, after this patch the following files still contain both
> 8-space and TAB sequences at the beginning of the line.  Many of them
> have a majority of TABs, or were initially committed with all tabs.

>     crypto/aes.c

Since you already cleaned some tabs in the previous patch, and the
rest of crypto/ except desrfb.c is tab-clean, I'd like this to be
fully cleaned too.


>     ui/vnc-enc-hextile-template.h
>     ui/vnc-enc-zywrle.h

The VNC code was historically heavily tab-damaged and we've
progressively cleaned it up when making changes. 

> The following have only TABs:

>     crypto/desrfb.c

I'd rather like this to be cleaned to finish the job for
crypto/.



> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---


>  ui/vnc-enc-zywrle-template.c               |  4 +-
>  ui/vnc.c                                   |  4 +-

That you've finished tab-cleaning of these files, reinforces to
me that we should clean those other vnc files listed above.

None the less

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

since those ones mentioned above can still be done as a separate
commit to this.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|