From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXkcg-00015V-QT for qemu-devel@nongnu.org; Fri, 14 Dec 2018 05:23:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXkcf-0002Ow-Rf for qemu-devel@nongnu.org; Fri, 14 Dec 2018 05:23:10 -0500 Date: Fri, 14 Dec 2018 10:22:11 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20181214102211.GF4265@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20181213223737.11793-1-pbonzini@redhat.com> <20181213223737.11793-3-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181213223737.11793-3-pbonzini@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] avoid TABs in files that only contain a few List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Kevin Wolf , Max Reitz , Stefan Weil , Viktor Prutyanov , Richard Henderson , Peter Maydell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Amit Shah , "Michael S. Tsirkin" , Stefano Stabellini , Anthony Perard , Andrzej Zaborowski , Gerd Hoffmann , Eduardo Habkost , Marcel Apfelbaum , John Snow , Aurelien Jarno , Aleksandar Markovic , Stefan Markovic , Jason Wang , Jiri Pirko , Dmitry Fleytman , David Gibson , =?utf-8?B?SGVydsOp?= Poussineau , Fam Zheng , Magnus Damm , Igor Mammedov , Riku Voipio , Laurent Vivier , Eric Blake , Thomas Huth , "Edgar E. Iglesias" , Alex =?utf-8?Q?Benn=C3=A9e?= , "open list:bochs" , "open list:Stellaris" , "open list:X86" , "open list:ppc4xx" On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote: > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. >=20 > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be exempted from the check. > Outside those, after this patch the following files still contain both > 8-space and TAB sequences at the beginning of the line. Many of them > have a majority of TABs, or were initially committed with all tabs. > crypto/aes.c Since you already cleaned some tabs in the previous patch, and the rest of crypto/ except desrfb.c is tab-clean, I'd like this to be fully cleaned too. > ui/vnc-enc-hextile-template.h > ui/vnc-enc-zywrle.h The VNC code was historically heavily tab-damaged and we've progressively cleaned it up when making changes.=20 > The following have only TABs: > crypto/desrfb.c I'd rather like this to be cleaned to finish the job for crypto/. > Signed-off-by: Paolo Bonzini > --- > ui/vnc-enc-zywrle-template.c | 4 +- > ui/vnc.c | 4 +- That you've finished tab-cleaning of these files, reinforces to me that we should clean those other vnc files listed above. None the less Reviewed-by: Daniel P. Berrang=C3=A9 since those ones mentioned above can still be done as a separate commit to this. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|