From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXl82-000371-Jd for qemu-devel@nongnu.org; Fri, 14 Dec 2018 05:55:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXl7x-0005Oa-KA for qemu-devel@nongnu.org; Fri, 14 Dec 2018 05:55:34 -0500 Received: from 19.mo3.mail-out.ovh.net ([178.32.98.231]:42283) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXl7x-0005It-7q for qemu-devel@nongnu.org; Fri, 14 Dec 2018 05:55:29 -0500 Received: from player787.ha.ovh.net (unknown [10.109.159.20]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 9A4251EB818 for ; Fri, 14 Dec 2018 11:55:19 +0100 (CET) Date: Fri, 14 Dec 2018 11:54:35 +0100 From: Greg Kurz Message-ID: <20181214115435.10e0b5a4@bahia.lan> In-Reply-To: <20181213223737.11793-3-pbonzini@redhat.com> References: <20181213223737.11793-1-pbonzini@redhat.com> <20181213223737.11793-3-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SPAM] [Qemu-ppc] [PATCH 2/2] avoid TABs in files that only contain a few List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Peter Maydell , Dmitry Fleytman , "Michael S. Tsirkin" , Jason Wang , Gerd Hoffmann , Fam Zheng , Eric Blake , Stefano Stabellini , "open list:bochs" , Stefan Markovic , Alex =?UTF-8?B?QmVubsOpZQ==?= , Magnus Damm , =?UTF-8?B?SGVydsOp?= Poussineau , Marcel Apfelbaum , Anthony Perard , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , David Gibson , Andrzej Zaborowski , Thomas Huth , Jiri Pirko , Eduardo Habkost , Amit Shah , Stefan Weil , Riku Voipio , "open list:Stellaris" , Stefan Hajnoczi , "open list:X86" , John Snow , Richard Henderson , Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , Viktor Prutyanov , Max Reitz , "open list:ppc4xx" , Aleksandar Markovic , Igor Mammedov On Thu, 13 Dec 2018 23:37:37 +0100 Paolo Bonzini wrote: > Most files that have TABs only contain a handful of them. Change > them to spaces so that we don't confuse people. > > disas, standard-headers, linux-headers and libdecnumber are imported > from other projects and probably should be exempted from the check. > Outside those, after this patch the following files still contain both > 8-space and TAB sequences at the beginning of the line. Many of them > have a majority of TABs, or were initially committed with all tabs. > > [...] > > Signed-off-by: Paolo Bonzini > --- This a lot of places to review... FWIW stgit spotted a trailing whitespace for free :) > > diff --git a/target/cris/helper.c b/target/cris/helper.c > index d2ec349191..754fa00d06 100644 > --- a/target/cris/helper.c > +++ b/target/cris/helper.c > @@ -240,7 +240,7 @@ void cris_cpu_do_interrupt(CPUState *cs) > /* Exception starts with dslot cleared. */ > env->dslot = 0; > } > - > +