From: "Emilio G. Cota" <cota@braap.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v5 0/3] Dynamic TLB sizing
Date: Fri, 14 Dec 2018 12:42:30 -0500 [thread overview]
Message-ID: <20181214174233.18027-1-cota@braap.org> (raw)
v4: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02679.html
Changes since v4:
- Rebase on v3.1.0. Quite a few conflicts, but the resulting diffs
are simpler than in v4.
- Re-run benchmarks on a different Skylake machine (this one is
a server with a lower clock frequency).
- Add comment on the resizing policy and mechanism.
- Change the downsizing policy. Instead of not downsizing until
a certain number of consecutive low use rates, keep track of
the max use rate in a given time window (100ms), and
downsize according to that max. This makes the policy resistant
to guests that flush *very* quickly and often (I was not happy
about just waiting until a certain number of flushes, since
we cannot know what that number should be for all guests).
The new policy has the shortcoming that since we check the
time on the host, if the host is overcommitted we might downsize
too aggressively. So the policy isn't perfect, but the gains
are big enough that we might want to merge this as a start.
Here's v4 vs. v5:
https://imgur.com/jkcFkdv
v4 is a little better for mcf, but v5 is better for xalancbmk,
and the average speedup is almost the same (1.48x vs. 1.51x,
respectively).
You can fetch this series from:
https://github.com/cota/qemu/tree/tlb-dyn-v5
Thanks,
Emilio
---
accel/tcg/cputlb.c | 186 ++++++++++++++++++++++++++++++++++++++++++++--
include/exec/cpu-all.h | 9 +++
include/exec/cpu-defs.h | 48 +++++++++++-
include/exec/cpu_ldst.h | 21 ++++++
tcg/aarch64/tcg-target.h | 1 +
tcg/arm/tcg-target.h | 1 +
tcg/i386/tcg-target.h | 1 +
tcg/i386/tcg-target.inc.c | 28 +++----
tcg/mips/tcg-target.h | 1 +
tcg/ppc/tcg-target.h | 1 +
tcg/s390/tcg-target.h | 1 +
tcg/sparc/tcg-target.h | 1 +
tcg/tci/tcg-target.h | 1 +
13 files changed, 278 insertions(+), 22 deletions(-)
next reply other threads:[~2018-12-14 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 17:42 Emilio G. Cota [this message]
2018-12-14 17:42 ` [Qemu-devel] [PATCH v5 1/3] cputlb: do not evict empty entries to the vtlb Emilio G. Cota
2018-12-14 17:42 ` [Qemu-devel] [PATCH v5 2/3] tcg: introduce dynamic TLB sizing Emilio G. Cota
2018-12-17 22:41 ` Emilio G. Cota
2018-12-26 6:51 ` Richard Henderson
2018-12-14 17:42 ` [Qemu-devel] [PATCH v5 3/3] tcg/i386: enable " Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214174233.18027-1-cota@braap.org \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).