From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXykZ-0005B0-8N for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXykU-0003Me-92 for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:15 -0500 Received: from m12-13.163.com ([220.181.12.13]:55494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXykT-0003L4-Cb for qemu-devel@nongnu.org; Fri, 14 Dec 2018 20:28:10 -0500 From: Li Qiang Date: Fri, 14 Dec 2018 17:26:23 -0800 Message-Id: <20181215012625.73315-2-liq3ea@163.com> In-Reply-To: <20181215012625.73315-1-liq3ea@163.com> References: <20181215012625.73315-1-liq3ea@163.com> Subject: [Qemu-devel] [PATCH 1/3] tests: vhost-user-test: initialize 'fd' in chr_read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, mst@redhat.com, peter.maydell@linaro.org, marcandre.lureau@redhat.com, berrange@redhat.com, jasowang@redhat.com Cc: liq3ea@gmail.com, qemu-devel@nongnu.org, Li Qiang Currentyly when processing VHOST_USER_SET_VRING_CALL if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will be a stack uninitialized value. Signed-off-by: Li Qiang --- tests/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 45d58d8ea2..86039e61e0 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -309,7 +309,7 @@ static void chr_read(void *opaque, const uint8_t *buf, int size) CharBackend *chr = &s->chr; VhostUserMsg msg; uint8_t *p = (uint8_t *) &msg; - int fd; + int fd = -1; if (s->test_fail) { qemu_chr_fe_disconnect(chr); -- 2.17.1