qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: nsoffer@redhat.com, jsnow@redhat.com, rjones@redhat.com,
	vsementsov@virtuozzo.com, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 01/22] qemu-nbd: Use program name in error messages
Date: Sat, 15 Dec 2018 07:53:03 -0600	[thread overview]
Message-ID: <20181215135324.152629-2-eblake@redhat.com> (raw)
In-Reply-To: <20181215135324.152629-1-eblake@redhat.com>

This changes output from:

$ qemu-nbd nosuch
Failed to blk_new_open 'nosuch': Could not open 'nosuch': No such file or directory

to something more consistent with qemu-img and qemu:

$ qemu-nbd nosuch
qemu-nbd: Failed to blk_new_open 'nosuch': Could not open 'nosuch': No such file or directory

Update the lone affected test to match.  (Hmm - is it sad that we don't
do much testing of expected failures?)

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 qemu-nbd.c                 | 1 +
 tests/qemu-iotests/233.out | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index ca7109652e5..e169b839ece 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -571,6 +571,7 @@ int main(int argc, char **argv)
 #endif

     module_call_init(MODULE_INIT_TRACE);
+    error_set_progname(argv[0]);
     qcrypto_init(&error_fatal);

     module_call_init(MODULE_INIT_QOM);
diff --git a/tests/qemu-iotests/233.out b/tests/qemu-iotests/233.out
index 94acd9b9479..5f416721b03 100644
--- a/tests/qemu-iotests/233.out
+++ b/tests/qemu-iotests/233.out
@@ -27,7 +27,7 @@ virtual size: 64M (67108864 bytes)
 disk size: unavailable

 == check TLS with different CA fails ==
-option negotiation failed: Verify failed: No certificate was found.
+qemu-nbd: option negotiation failed: Verify failed: No certificate was found.
 qemu-img: Could not open 'driver=nbd,host=127.0.0.1,port=PORT,tls-creds=tls0': The certificate hasn't got a known issuer

 == perform I/O over TLS ==
-- 
2.17.2

  reply	other threads:[~2018-12-15 13:53 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-15 13:53 [Qemu-devel] [PATCH v2 00/22] nbd: add qemu-nbd --list Eric Blake
2018-12-15 13:53 ` Eric Blake [this message]
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 02/22] nbd: Document timeline of various features Eric Blake
2018-12-15 14:02   ` Richard W.M. Jones
2018-12-18 13:03   ` Vladimir Sementsov-Ogievskiy
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 03/22] maint: Allow for EXAMPLES in texi2pod Eric Blake
2018-12-15 14:04   ` Richard W.M. Jones
2018-12-18 13:46   ` Vladimir Sementsov-Ogievskiy
2019-01-04 23:45     ` Eric Blake
2019-01-11  2:56       ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 04/22] qemu-nbd: Enhance man page Eric Blake
2018-12-15 14:13   ` Richard W.M. Jones
2018-12-17 15:19     ` Eric Blake
2019-01-04 23:47       ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 05/22] nbd/client: More consistent error messages Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 06/22] qemu-nbd: Fail earlier for -c/-d on non-linux Eric Blake
2018-12-15 14:15   ` Richard W.M. Jones
2018-12-18 14:26   ` Vladimir Sementsov-Ogievskiy
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 07/22] qemu-nbd: Avoid strtol open-coding Eric Blake
2018-12-15 14:17   ` Richard W.M. Jones
2018-12-18 15:11   ` Vladimir Sementsov-Ogievskiy
2019-01-04 23:50     ` Eric Blake
2019-01-11 22:47       ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 08/22] nbd/client: Drop pointless buf variable Eric Blake
2019-01-05 13:54   ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 09/22] nbd/client: Refactor nbd_receive_list() Eric Blake
2018-12-15 15:07   ` Richard W.M. Jones
2018-12-19 13:11   ` Vladimir Sementsov-Ogievskiy
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 10/22] nbd/client: Move export name into NBDExportInfo Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 11/22] nbd/client: Change signature of nbd_negotiate_simple_meta_context() Eric Blake
2018-12-15 15:12   ` Richard W.M. Jones
2018-12-20 13:37   ` Vladimir Sementsov-Ogievskiy
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 12/22] nbd/client: Improve error handling in nbd_negotiate_simple_meta_context() Eric Blake
2018-12-15 15:19   ` Richard W.M. Jones
2018-12-17 15:26     ` Eric Blake
2018-12-17 15:30     ` Eric Blake
2018-12-20 14:13       ` Vladimir Sementsov-Ogievskiy
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 13/22] nbd/client: Split out nbd_send_one_meta_context() Eric Blake
2018-12-15 15:22   ` Richard W.M. Jones
2018-12-17 15:34     ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 14/22] nbd/client: Split out nbd_receive_one_meta_context() Eric Blake
2018-12-15 15:30   ` Richard W.M. Jones
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 15/22] nbd/client: Refactor return of nbd_receive_negotiate() Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 16/22] nbd/client: Split handshake into two functions Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 17/22] nbd/client: Pull out oldstyle size determination Eric Blake
2018-12-15 15:31   ` Richard W.M. Jones
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 18/22] nbd/client: Add nbd_receive_export_list() Eric Blake
2018-12-15 15:42   ` Richard W.M. Jones
2018-12-17 15:43     ` Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 19/22] nbd/client: Add meta contexts to nbd_receive_export_list() Eric Blake
2018-12-15 15:59   ` Richard W.M. Jones
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 20/22] qemu-nbd: Add --list option Eric Blake
2018-12-15 16:02   ` Richard W.M. Jones
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 21/22] nbd/client: Work around 3.0 bug for listing meta contexts Eric Blake
2018-12-15 13:53 ` [Qemu-devel] [PATCH v2 22/22] iotests: Enhance 223, 233 to cover 'qemu-nbd --list' Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181215135324.152629-2-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=nsoffer@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).