qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Li Qiang <liq3ea@gmail.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	rth@twiddle.net, ehabkost@redhat.com,
	Darren Kenny <darren.kenny@oracle.com>,
	Markus Armbruster <armbru@redhat.com>,
	Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR
Date: Sun, 16 Dec 2018 21:25:21 -0500	[thread overview]
Message-ID: <20181216212513-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAKXe6SL+aYFgbHDHq2jBogfBDKrO3a1=xaKyqeNV_-f_Gm5DAw@mail.gmail.com>

On Mon, Dec 17, 2018 at 09:10:06AM +0800, Li Qiang wrote:
> Ping....Paolo, could these patches go to your misc tree?
> 
> Thanks,
> Li Qiang


Fine by me

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> Li Qiang <liq3ea@gmail.com> 于2018年11月29日周四下午12:53写道:
> 
>     According https://wiki.qemu.org/Contribute/BiteSizedTasks
>     the 'DEFINE_PROP_PTR' should be replaced by QOM link property.
>     The first patch replace constant strings with TYPE_XXXX and move some
>     definition to pc.h header file so that the second patch can work.
> 
>     Change since v2: detail commit message
>     Change since v1: fix some issues per Markus' review
> 
>     Li Qiang (2):
>       hw: pc: use TYPE_XXX instead of constant strings
>       hw: vmmouse: Use link instead of pointer property
> 
>      hw/i386/pc.c         |  9 +++++----
>      hw/i386/vmmouse.c    | 18 +++++++++++-------
>      include/hw/i386/pc.h |  3 +++
>      3 files changed, 19 insertions(+), 11 deletions(-)
> 
>     --
>     2.11.0
> 
> 

      reply	other threads:[~2018-12-17  2:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  4:52 [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR Li Qiang
2018-11-29  4:52 ` [Qemu-devel] [PATCH v3 1/2] hw: pc: use TYPE_XXX instead of constant strings Li Qiang
2018-12-17 12:32   ` Philippe Mathieu-Daudé
2018-11-29  4:52 ` [Qemu-devel] [PATCH v3 2/2] hw: vmmouse: Use link instead of pointer property Li Qiang
2018-12-17 12:43   ` Philippe Mathieu-Daudé
2018-12-17 19:01     ` Markus Armbruster
2018-12-17 19:37       ` Philippe Mathieu-Daudé
2018-12-18  7:09         ` Markus Armbruster
2018-12-18  8:49           ` Li Qiang
2018-12-17  1:10 ` [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR Li Qiang
2018-12-17  2:25   ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181216212513-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=armbru@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=ehabkost@redhat.com \
    --cc=liq3ea@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).