qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	peterx@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [Qemu-devel] [PATCH 1/5] intel_iommu: dump correct iova when failed
Date: Mon, 17 Dec 2018 15:31:10 +0800	[thread overview]
Message-ID: <20181217073114.11984-2-peterx@redhat.com> (raw)
In-Reply-To: <20181217073114.11984-1-peterx@redhat.com>

The iotlb.iova can be zero if failure really happened.  Dump the addr
instead.

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 hw/i386/intel_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index d97bcbc2f7..f21988f396 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2540,7 +2540,7 @@ static IOMMUTLBEntry vtd_iommu_translate(IOMMUMemoryRegion *iommu, hwaddr addr,
                           __func__, pci_bus_num(vtd_as->bus),
                           VTD_PCI_SLOT(vtd_as->devfn),
                           VTD_PCI_FUNC(vtd_as->devfn),
-                          iotlb.iova);
+                          addr);
     }
 
     return iotlb;
-- 
2.17.1

  reply	other threads:[~2018-12-17  7:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  7:31 [Qemu-devel] [PATCH 0/5] intel_iommu: fix windows svvp verification, and trivial cleanups Peter Xu
2018-12-17  7:31 ` Peter Xu [this message]
2018-12-17  7:31 ` [Qemu-devel] [PATCH 2/5] intel_iommu: convert invalid traces into error reports Peter Xu
2018-12-17  7:31 ` [Qemu-devel] [PATCH 3/5] intel_iommu: dma read/write draining support Peter Xu
2018-12-17  7:31 ` [Qemu-devel] [PATCH 4/5] intel_iommu: remove "x-" prefix for "aw-bits" Peter Xu
2018-12-17  7:31 ` [Qemu-devel] [PATCH 5/5] intel_iommu: turn on IR by default Peter Xu
2018-12-18  3:07   ` Peter Xu
2018-12-18 12:30     ` Paolo Bonzini
2018-12-19  5:21       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217073114.11984-2-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).