qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PULL 21/35] qga: drop < Vista compatibility
Date: Tue, 18 Dec 2018 00:16:46 +0100	[thread overview]
Message-ID: <20181217231700.24482-22-pbonzini@redhat.com> (raw)
In-Reply-To: <20181217231700.24482-1-pbonzini@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Building QGA for XP seems possible so far: the dependency on
libqemuutil.a implies building qemu-thread-win32.c, which requires
Vista API since commit 12f8def0 (v2.9). But qemu-thread isn't being
used in QGA, the resulting binary may still work on XP.  XP is no
longer supported for the past 4.5y, it's time to drop support for it.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181122110039.15972-5-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qga/commands-win32.c | 64 --------------------------------------------
 1 file changed, 64 deletions(-)

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index f03b9c1d89..989b93e702 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -466,13 +466,11 @@ static STORAGE_BUS_TYPE win2qemu[] = {
     [BusTypeFibre] = GUEST_DISK_BUS_TYPE_SSA,
     [BusTypeUsb] = GUEST_DISK_BUS_TYPE_USB,
     [BusTypeRAID] = GUEST_DISK_BUS_TYPE_RAID,
-#if (_WIN32_WINNT >= 0x0600)
     [BusTypeiScsi] = GUEST_DISK_BUS_TYPE_ISCSI,
     [BusTypeSas] = GUEST_DISK_BUS_TYPE_SAS,
     [BusTypeSata] = GUEST_DISK_BUS_TYPE_SATA,
     [BusTypeSd] =  GUEST_DISK_BUS_TYPE_SD,
     [BusTypeMmc] = GUEST_DISK_BUS_TYPE_MMC,
-#endif
 #if (_WIN32_WINNT >= 0x0601)
     [BusTypeVirtual] = GUEST_DISK_BUS_TYPE_VIRTUAL,
     [BusTypeFileBackedVirtual] = GUEST_DISK_BUS_TYPE_FILE_BACKED_VIRTUAL,
@@ -724,10 +722,8 @@ static void get_single_disk_info(GuestDiskAddress *disk, Error **errp)
     if (disk->bus_type == GUEST_DISK_BUS_TYPE_SCSI
             || disk->bus_type == GUEST_DISK_BUS_TYPE_IDE
             || disk->bus_type == GUEST_DISK_BUS_TYPE_RAID
-#if (_WIN32_WINNT >= 0x0600)
             /* This bus type is not supported before Windows Server 2003 SP1 */
             || disk->bus_type == GUEST_DISK_BUS_TYPE_SAS
-#endif
         ) {
         /* We are able to use the same ioctls for different bus types
          * according to Microsoft docs
@@ -1322,7 +1318,6 @@ static char *guest_addr_to_str(IP_ADAPTER_UNICAST_ADDRESS *ip_addr,
     return NULL;
 }
 
-#if (_WIN32_WINNT >= 0x0600)
 static int64_t guest_ip_prefix(IP_ADAPTER_UNICAST_ADDRESS *ip_addr)
 {
     /* For Windows Vista/2008 and newer, use the OnLinkPrefixLength
@@ -1330,60 +1325,6 @@ static int64_t guest_ip_prefix(IP_ADAPTER_UNICAST_ADDRESS *ip_addr)
      */
     return ip_addr->OnLinkPrefixLength;
 }
-#else
-/* When using the Windows XP and 2003 build environment, do the best we can to
- * figure out the prefix.
- */
-static IP_ADAPTER_INFO *guest_get_adapters_info(void)
-{
-    IP_ADAPTER_INFO *adptr_info = NULL;
-    ULONG adptr_info_len = 0;
-    DWORD ret;
-
-    /* Call the first time to get the adptr_info_len. */
-    GetAdaptersInfo(adptr_info, &adptr_info_len);
-
-    adptr_info = g_malloc(adptr_info_len);
-    ret = GetAdaptersInfo(adptr_info, &adptr_info_len);
-    if (ret != ERROR_SUCCESS) {
-        g_free(adptr_info);
-        adptr_info = NULL;
-    }
-    return adptr_info;
-}
-
-static int64_t guest_ip_prefix(IP_ADAPTER_UNICAST_ADDRESS *ip_addr)
-{
-    int64_t prefix = -1; /* Use for AF_INET6 and unknown/undetermined values. */
-    IP_ADAPTER_INFO *adptr_info, *info;
-    IP_ADDR_STRING *ip;
-    struct in_addr *p;
-
-    if (ip_addr->Address.lpSockaddr->sa_family != AF_INET) {
-        return prefix;
-    }
-    adptr_info = guest_get_adapters_info();
-    if (adptr_info == NULL) {
-        return prefix;
-    }
-
-    /* Match up the passed in ip_addr with one found in adaptr_info.
-     * The matching one in adptr_info will have the netmask.
-     */
-    p = &((struct sockaddr_in *)ip_addr->Address.lpSockaddr)->sin_addr;
-    for (info = adptr_info; info; info = info->Next) {
-        for (ip = &info->IpAddressList; ip; ip = ip->Next) {
-            if (p->S_un.S_addr == inet_addr(ip->IpAddress.String)) {
-                prefix = ctpop32(inet_addr(ip->IpMask.String));
-                goto out;
-            }
-        }
-    }
-out:
-    g_free(adptr_info);
-    return prefix;
-}
-#endif
 
 #define INTERFACE_PATH_BUF_SZ 512
 
@@ -1904,7 +1845,6 @@ typedef struct _GA_WTSINFOA {
 
 GuestUserList *qmp_guest_get_users(Error **err)
 {
-#if (_WIN32_WINNT >= 0x0600)
 #define QGA_NANOSECONDS 10000000
 
     GHashTable *cache = NULL;
@@ -1974,10 +1914,6 @@ GuestUserList *qmp_guest_get_users(Error **err)
     }
     g_hash_table_destroy(cache);
     return head;
-#else
-    error_setg(err, QERR_UNSUPPORTED);
-    return NULL;
-#endif
 }
 
 typedef struct _ga_matrix_lookup_t {
-- 
2.20.1

  parent reply	other threads:[~2018-12-17 23:17 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 23:16 [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18 Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 01/35] accel: Improve selection of the default accelerator Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 02/35] vhost-user-bridge: fix "unknown type name" compilation error Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 03/35] checkpatch: fix premature exit when no input or --mailback Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 04/35] checkpatch: check Signed-off-by in --mailback mode Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 05/35] checkpatch: improve handling of multiple patches or files Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 06/35] checkpatch: colorize output to terminal Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 07/35] pam: wrap MemoryRegion initialization in a transaction Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 08/35] memory: extract flat_range_coalesced_io_{del, add} Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 09/35] memory: avoid unnecessary coalesced_io_del operations Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 10/35] memory: update coalesced_range on transaction_commit Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 11/35] hax: Support for Linux hosts Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 12/35] block/iscsi: drop unused IscsiAIOCB->buf field Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 13/35] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 14/35] block/iscsi: fix ioctl cancel use-after-free Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 15/35] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 16/35] esp-pci: Fix status register write erase control Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 17/35] scsi: esp: Defer command completion until previous interrupts have been handled Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 18/35] build-sys: don't include windows.h, osdep.h does it Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 19/35] build-sys: move windows defines in osdep.h header Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 20/35] build-sys: build with Vista API by default Paolo Bonzini
2018-12-17 23:16 ` Paolo Bonzini [this message]
2018-12-17 23:16 ` [Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 23/35] test: replace gtester with a TAP driver Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 24/35] qemu/queue.h: do not access tqe_prev directly Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 25/35] vfio: make vfio_address_spaces static Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 26/35] qemu/queue.h: leave head structs anonymous unless necessary Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 27/35] qemu/queue.h: typedef QTAILQ heads Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 28/35] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY} Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 29/35] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 30/35] qemu/queue.h: simplify reverse access to QTAILQ Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 31/35] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 32/35] hw/watchdog/wdt_i6300esb: remove a unnecessary comment Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 33/35] scripts: add script to convert multiline comments into 4-line format Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 34/35] remove space-tab sequences Paolo Bonzini
2018-12-17 23:17 ` [Qemu-devel] [PULL 35/35] avoid TABs in files that only contain a few Paolo Bonzini
2018-12-19 14:33 ` [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18 Peter Maydell
2018-12-19 15:05   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2018-12-19 15:18 [Qemu-devel] [PULL v2 " Paolo Bonzini
2018-12-19 15:19 ` [Qemu-devel] [PULL 21/35] qga: drop < Vista compatibility Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217231700.24482-22-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).