qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>
Subject: [Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped
Date: Tue, 18 Dec 2018 00:16:47 +0100	[thread overview]
Message-ID: <20181217231700.24482-23-pbonzini@redhat.com> (raw)
In-Reply-To: <20181217231700.24482-1-pbonzini@redhat.com>

Sometimes a test's main() function recognizes that the environment
does not support the test, and therefore exits.  In this case, we
still should run g_test_run() so that a TAP harness will print the
test plan ("1..0") and the test will be marked as skipped.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1543513531-1151-2-git-send-email-pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/cdrom-test.c     | 2 +-
 tests/migration-test.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/cdrom-test.c b/tests/cdrom-test.c
index 9b43dc9ab4..14bd981336 100644
--- a/tests/cdrom-test.c
+++ b/tests/cdrom-test.c
@@ -169,7 +169,7 @@ int main(int argc, char **argv)
 
     if (exec_genisoimg(genisocheck)) {
         /* genisoimage not available - so can't run tests */
-        return 0;
+        return g_test_run();
     }
 
     ret = prepare_image(arch, isoimage);
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 06ca5068d8..8352612364 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -789,7 +789,7 @@ int main(int argc, char **argv)
     g_test_init(&argc, &argv, NULL);
 
     if (!ufd_version_check()) {
-        return 0;
+        return g_test_run();
     }
 
     /*
@@ -800,7 +800,7 @@ int main(int argc, char **argv)
     if (g_str_equal(qtest_get_arch(), "ppc64") &&
         access("/sys/module/kvm_hv", F_OK)) {
         g_test_message("Skipping test: kvm_hv not available");
-        return 0;
+        return g_test_run();
     }
 
     /*
@@ -811,11 +811,11 @@ int main(int argc, char **argv)
 #if defined(HOST_S390X)
         if (access("/dev/kvm", R_OK | W_OK)) {
             g_test_message("Skipping test: kvm not available");
-            return 0;
+            return g_test_run();
         }
 #else
         g_test_message("Skipping test: Need s390x host to work properly");
-        return 0;
+        return g_test_run();
 #endif
     }
 
-- 
2.20.1

  parent reply	other threads:[~2018-12-17 23:17 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 23:16 [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18 Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 01/35] accel: Improve selection of the default accelerator Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 02/35] vhost-user-bridge: fix "unknown type name" compilation error Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 03/35] checkpatch: fix premature exit when no input or --mailback Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 04/35] checkpatch: check Signed-off-by in --mailback mode Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 05/35] checkpatch: improve handling of multiple patches or files Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 06/35] checkpatch: colorize output to terminal Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 07/35] pam: wrap MemoryRegion initialization in a transaction Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 08/35] memory: extract flat_range_coalesced_io_{del, add} Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 09/35] memory: avoid unnecessary coalesced_io_del operations Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 10/35] memory: update coalesced_range on transaction_commit Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 11/35] hax: Support for Linux hosts Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 12/35] block/iscsi: drop unused IscsiAIOCB->buf field Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 13/35] block/iscsi: take iscsilun->mutex in iscsi_timed_check_events() Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 14/35] block/iscsi: fix ioctl cancel use-after-free Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 15/35] block/iscsi: cancel libiscsi task when ABORT TASK TMF completes Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 16/35] esp-pci: Fix status register write erase control Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 17/35] scsi: esp: Defer command completion until previous interrupts have been handled Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 18/35] build-sys: don't include windows.h, osdep.h does it Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 19/35] build-sys: move windows defines in osdep.h header Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 20/35] build-sys: build with Vista API by default Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 21/35] qga: drop < Vista compatibility Paolo Bonzini
2018-12-17 23:16 ` Paolo Bonzini [this message]
2018-12-17 23:16 ` [Qemu-devel] [PULL 23/35] test: replace gtester with a TAP driver Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 24/35] qemu/queue.h: do not access tqe_prev directly Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 25/35] vfio: make vfio_address_spaces static Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 26/35] qemu/queue.h: leave head structs anonymous unless necessary Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 27/35] qemu/queue.h: typedef QTAILQ heads Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 28/35] qemu/queue.h: remove Q_TAILQ_{HEAD, ENTRY} Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 29/35] qemu/queue.h: reimplement QTAILQ without pointer-to-pointers Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 30/35] qemu/queue.h: simplify reverse access to QTAILQ Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 31/35] checkpatch: warn about qemu/queue.h head structs that are not typedef-ed Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 32/35] hw/watchdog/wdt_i6300esb: remove a unnecessary comment Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 33/35] scripts: add script to convert multiline comments into 4-line format Paolo Bonzini
2018-12-17 23:16 ` [Qemu-devel] [PULL 34/35] remove space-tab sequences Paolo Bonzini
2018-12-17 23:17 ` [Qemu-devel] [PULL 35/35] avoid TABs in files that only contain a few Paolo Bonzini
2018-12-19 14:33 ` [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18 Peter Maydell
2018-12-19 15:05   ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2018-12-19 15:18 [Qemu-devel] [PULL v2 " Paolo Bonzini
2018-12-19 15:19 ` [Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped Paolo Bonzini
2018-12-20 12:36 [Qemu-devel] [PULL v3 00/35] Misc patches for 2018-12-18 Paolo Bonzini
2018-12-20 12:36 ` [Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped Paolo Bonzini
2018-12-21 12:36 [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21 Paolo Bonzini
2018-12-21 12:36 ` [Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217231700.24482-23-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).